Date: Tue, 17 Mar 2026 11:24:07 +0000 From: Andrew Turner <andrew@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Sarah Walker <sarah.walker2@arm.com> Subject: git: 1d13d938fe6c - main - virtio: Ensure power-of-two alignment for indirect queue Message-ID: <69b939d7.26113.1aca36de@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=1d13d938fe6c7639d2bb4cb5248a1f81275b6891 commit 1d13d938fe6c7639d2bb4cb5248a1f81275b6891 Author: Sarah Walker <sarah.walker2@arm.com> AuthorDate: 2026-03-17 10:54:30 +0000 Commit: Andrew Turner <andrew@FreeBSD.org> CommitDate: 2026-03-17 10:56:27 +0000 virtio: Ensure power-of-two alignment for indirect queue Some platforms enforce power-of-two alignment for bus_dma tags. Rounding up the natural size may result in over-alignment, but should be safe. PR: 293770 Reviewed by: andrew Fixes: c499ad6f997c ("virtio: Use bus_dma for ring and indirect buffer allocations") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D55843 --- sys/dev/virtio/virtqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c index b7fdb4703ccb..10b5179bd3d5 100644 --- a/sys/dev/virtio/virtqueue.c +++ b/sys/dev/virtio/virtqueue.c @@ -341,7 +341,7 @@ virtqueue_init_indirect(struct virtqueue *vq, int indirect_size) align = size; error = bus_dma_tag_create( bus_get_dma_tag(dev), /* parent */ - align, /* alignment */ + roundup_pow_of_two(align), /* alignment */ 0, /* boundary */ BUS_SPACE_MAXADDR, /* lowaddr */ BUS_SPACE_MAXADDR, /* highaddr */home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69b939d7.26113.1aca36de>