Date: Thu, 15 Jan 2009 17:55:00 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: sobomax@FreeBSD.org Cc: danfe@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, stas@FreeBSD.org, gonzo@FreeBSD.org, svn-src-head@FreeBSD.org, christoph.mallon@gmx.de Subject: Re: svn commit: r187251 - head/sys/mips/malta Message-ID: <20090115.175500.692488694.imp@bsdimp.com> In-Reply-To: <496FC32F.3040104@FreeBSD.org> References: <20090115114407.GA67726@FreeBSD.org> <496F24D8.2040104@gmx.de> <496FC32F.3040104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <496FC32F.3040104@FreeBSD.org>
Maxim Sobolev <sobomax@FreeBSD.org> writes:
: Christoph Mallon wrote:
: > Alexey Dokuchaev schrieb:
: >> On Wed, Jan 14, 2009 at 07:05:27PM -0700, M. Warner Losh wrote:
: >>> In message: <20090115020752.52566769.stas@FreeBSD.org>
: >>> Stanislav Sedov <stas@FreeBSD.org> writes:
: >>> : > + shift = 8 * (reg & 3);
: >>> : > : : Would it make sense to replace this with
: >>> : > + shift = (reg & 3) << 3;
: >>> : : to not rely on possible compiler optimizations?
: >>>
: >>> I don't think that it matters all that much these days...
: >>
: >> But the name "shift" kinda suggests << instead of *, no?
: >
: > The value *is* a shift amount (see its uses a few lines down). Its name
: > does not imply the way it is calculated, but what it is used for.
: >
: > BTW: Even the most cheap compilers emit shift instructions for
: > multiplication by a power of two. The new code also is clearly faster
: > then the old - quite some code gets generated for switches.
:
: I believe Warner's point is that the code is not in the hot path, so
: that it should not really matter either way.
The code is clear the way it is, there's little reason to
hyper-optimize this path in the face of bogus compiler optimizations
or not, and the effort to optimize the hot-path should be aided by
dtrace or kernel profiling rather than reading the code.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090115.175500.692488694.imp>