Date: Sat, 26 Aug 2006 10:27:52 +0200 From: Wilko Bulte <wb@freebie.xs4all.nl> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-src@FreeBSD.ORG, Guido van Rooij <guido@gvr.org>, Alexander Kabaev <kabaev@gmail.com> Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... Message-ID: <20060826082751.GA11942@freebie.xs4all.nl> In-Reply-To: <20060826023120.GA74468@troutmask.apl.washington.edu> References: <200608240737.k7O7bDMC085424@repoman.freebsd.org> <20060824092002.44b90594@kan.dnsalias.net> <20060824133628.GA54467@gvr.gvr.org> <20060824101606.414e8bf6@kan.dnsalias.net> <20060824205854.GA59856@gvr.gvr.org> <20060824184402.2ee29d79@kan.dnsalias.net> <20060826020854.GD16768@turion.vk2pj.dyndns.org> <20060826023120.GA74468@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 25, 2006 at 07:31:20PM -0700, Steve Kargl wrote.. > On Sat, Aug 26, 2006 at 12:08:54PM +1000, Peter Jeremy wrote: > > On Thu, 2006-Aug-24 18:44:02 -0400, Alexander Kabaev wrote: > > >personally. The mistake you made just shows how important it is to do a > > >buildworld _from freshly checked out sources_ after every major vendor > > >import. > > > > I'm not sure how doing this would have prevented the breakage. It > > might have allowed Guido to notice the breakage more quickly. > > It would have caught the first problem, which I reported here > http://lists.freebsd.org/pipermail/freebsd-current/2006-August/065175.html. > This problem was fixed by kan as noted here > http://lists.freebsd.org/pipermail/cvs-src/2006-August/067536.html > > Notice I reported the problem of Aug 16th. Kan's patch was committed > on Aug 17th. > > > Guido made a mistake, has apologised and has corrected the problem in > > less than 6 hours. > > He only corrected the second problem caused by his commit. Can we please stop this moaning about Guido's work? Mistakes do get made, and in this case were fixed rapidly. Please move on, nothing here to see anymore. -- Wilko Bulte wilko@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060826082751.GA11942>