Date: Thu, 18 Jun 2020 08:23:49 -0400 From: Ed Maste <emaste@freebsd.org> To: Andrew Turner <andrew@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362285 - head/sys/dev/pci Message-ID: <CAPyFy2C2nRF9akKthA8SbpxigWcNFNQr-Dt1Q33RxyG4gjNDvg@mail.gmail.com> In-Reply-To: <202006171956.05HJuH8B032154@repo.freebsd.org> References: <202006171956.05HJuH8B032154@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 17 Jun 2020 at 15:56, Andrew Turner <andrew@freebsd.org> wrote: > > Author: andrew > Date: Wed Jun 17 19:56:17 2020 > New Revision: 362285 > URL: https://svnweb.freebsd.org/changeset/base/362285 > > Log: > Clean up the pci host generic driver ... > > + /* Translate the address from a PCI address to a physical address */ > + switch (type) { > + case SYS_RES_IOPORT: > + case SYS_RES_MEMORY: > + found = false; > + for (i = 0; i < MAX_RANGES_TUPLES; i++) { > + pci_base = sc->ranges[i].pci_base; > + phys_base = sc->ranges[i].phys_base; > + size = sc->ranges[i].size; > + > + if (start < pci_base || start >= pci_base + size) > + continue; Should the second condition be end instead? markj had this comment on the old version in review D20884.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2C2nRF9akKthA8SbpxigWcNFNQr-Dt1Q33RxyG4gjNDvg>