Date: Fri, 11 Jun 2010 08:50:16 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: "Daniel O'Connor" <doconnor@gsoft.com.au> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: SPOOFED: Re: svn commit: r209011 - stable/8/sys/dev/ath/ath_hal/ar5211 Message-ID: <7E348ECC-5F60-4788-99F5-4B8D88E3AF65@freebsd.org> In-Reply-To: <3BE36947-BCB4-4A6D-9040-873CFD144F3B@gsoft.com.au> References: <201006102034.o5AKYMXX058081@svn.freebsd.org> <3BE36947-BCB4-4A6D-9040-873CFD144F3B@gsoft.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11 Jun 2010, at 02:46, Daniel O'Connor wrote:
>
> On 11/06/2010, at 6:04, Rui Paulo wrote:
>> Log:
>> MFC r208644:
>> Due to the way HALDEBUG() is defined, we need to add curly brackets
>> when using it as a sole if clause instruction.
>> While there, fix 'const static' typo.
>
> Why not fix HALDEBUG? ie wrap it in do { } while (0)
>
> Although that said when I looked at HALDEBUG on 8.0 it was defined as a function so it is a non issue there.
>
> HAL_DEBUG is different but I can't actually find where that is defined.
There's actually no problem in the code. This was to shut up a compiler warning on NetBSD. I probably should've said that in the commit log.
Regards,
--
Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7E348ECC-5F60-4788-99F5-4B8D88E3AF65>