Date: Wed, 1 Nov 1995 15:46:21 +0800 (WST) From: Peter Wemm <peter@jhome.DIALix.COM> To: Bruce Evans <bde@zeta.org.au> Cc: davidg@Root.COM, CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/kern tty_subr.c Message-ID: <Pine.BSF.3.91.951101153052.22432Q-100000@jhome.DIALix.COM> In-Reply-To: <199511010555.QAA17404@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 1 Nov 1995, Bruce Evans wrote: > >I used to have this problem occasionally with the specialix driver, and in > >the end the interrupt routine had to do a lot of tests to attempt to > >intuit whether or not he cblocks were currently reserved or not. The > > That's why I don't like silently ignoring the problem. Reporting it > nastily should have been good for getting drivers fixed. si.c was > relying on TS_CONNECTED but TS_CONNECTED isn't set quite right for it. > TS_CONNECTED shouldn't be set in ttymodem() unless TS_ISOPEN is set. > If you fix this, then change the recent fix to ttyopen() to set > TS_CONNECTED if carrier is on as well as if CLOCAL is set. > > Bruce My main thoughts on the issue is that it doesn't _need_ to panic.. :-) The system can quite safely recover from it. Yes, a nasty message is a good idea, but bombing the kernel seems a little drastic. Cheers, -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.91.951101153052.22432Q-100000>