Date: Sun, 12 Sep 2004 04:37:33 +0200 (CEST) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71617: [PATCH] cleanup of the usr.sbin/ypserv code Message-ID: <200409120237.i8C2bXEB007094@kulesh.obluda.cz> Resent-Message-ID: <200409120240.i8C2eNcc086943@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71617
>Category: bin
>Synopsis: [PATCH] cleanup of the usr.sbin/ypserv code
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 12 02:40:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/ypserv/yp_main.c,v 1.26 2003/05/03 21:06:42 obrien
usr.sbin/ypserv/yp_dnslookup.c,v 1.24 2003/05/03 21:06:42 obrien
>Description:
There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.
Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.
I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.
usr.sbin/ypserv/yp_dnslookup.c:347: warning: unused variable `retrybuf'
usr.sbin/ypserv/yp_dnslookup.c:454: warning: int format, long unsigned int arg (arg 2)
usr.sbin/ypserv/yp_dnslookup.c:518: warning: int format, long unsigned int arg (arg 2)
usr.sbin/ypserv/yp_main.c:109: warning: unused variable `forked'
>How-To-Repeat:
N/A
>Fix:
*** usr.sbin/ypserv/yp_dnslookup.c.ORIG Thu May 29 19:34:29 2003
--- usr.sbin/ypserv/yp_dnslookup.c Sun Sep 5 19:08:30 2004
***************
*** 344,350 ****
{
register struct circleq_dnsentry *q;
char buf[sizeof(HEADER) + MAXPACKET];
- char retrybuf[MAXHOSTNAMELEN];
struct sockaddr_in sin;
int rval;
int len;
--- 344,349 ----
***************
*** 451,457 ****
pending++;
if (debug)
! yp_error("queueing async DNS name lookup (%d)", q->id);
yp_prune_dnsq();
return(YP_TRUE);
--- 450,456 ----
pending++;
if (debug)
! yp_error("queueing async DNS name lookup (%lu)", q->id);
yp_prune_dnsq();
return(YP_TRUE);
***************
*** 515,521 ****
pending++;
if (debug)
! yp_error("queueing async DNS address lookup (%d)", q->id);
yp_prune_dnsq();
return(YP_TRUE);
--- 514,520 ----
pending++;
if (debug)
! yp_error("queueing async DNS address lookup (%lu)", q->id);
yp_prune_dnsq();
return(YP_TRUE);
*** usr.sbin/ypserv/yp_main.c.ORIG Thu May 29 19:34:29 2003
--- usr.sbin/ypserv/yp_main.c Sun Sep 5 19:09:31 2004
***************
*** 106,112 ****
#else
int readfds;
#endif /* def FD_SETSIZE */
- extern int forked;
int fd_setsize = _rpc_dtablesize();
struct timeval timeout;
--- 106,111 ----
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409120237.i8C2bXEB007094>