Date: Wed, 4 May 2016 20:05:10 -0600 From: Warner Losh <imp@bsdimp.com> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Gleb Smirnoff <glebius@freebsd.org>, Garrett Cooper <ngie@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r299086 - head Message-ID: <CANCZdfpU39MDRmxe4WYxCKKC_jHFiYOeyd%2BTBEROrCpk7X7Uwg@mail.gmail.com> In-Reply-To: <07EA9409-1155-4D47-BD81-D03C675A35CE@gmail.com> References: <201605042100.u44L0fdS023680@repo.freebsd.org> <3C136183-85D6-4047-8F2B-FB1B6C310AFF@gmail.com> <20160505003135.GH1369@FreeBSD.org> <07EA9409-1155-4D47-BD81-D03C675A35CE@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
BTW, why is this a new NO_XXXX thing? It should be MK_XXXX instead... Warner On Wed, May 4, 2016 at 6:47 PM, Ngie Cooper (yaneurabeya) < yaneurabeya@gmail.com> wrote: > > > On May 4, 2016, at 17:31, Gleb Smirnoff <glebius@FreeBSD.org> wrote: > > > > On Wed, May 04, 2016 at 02:06:33PM -0700, Ngie Cooper (yaneurabeya) > wrote: > > N> > > N> > On May 4, 2016, at 14:00, Garrett Cooper <ngie@FreeBSD.org> wrote: > > N> > > > N> > Author: ngie > > N> > Date: Wed May 4 21:00:41 2016 > > N> > New Revision: 299086 > > N> > URL: https://svnweb.freebsd.org/changeset/base/299086 > > N> > > > N> > Log: > > N> > Default NO_INSTALLEXTRAKERNELS to "no" to unbreak the build > > N> > > > N> > MFC after: soon (was insta-MFCed -_-..) > > N> > Pointyhat to: glebius > > N> > Sponsored by: EMC / Isilon Storage Division > > N> > > > N> > Modified: > > N> > head/Makefile.inc1 > > > > Defaulting it to "no" you changed the behaviour backwards, which is > > wrong. > > Agreed. That=E2=80=99s why I inverted it back to =E2=80=9Cyes=E2=80=9D in= r299088. > > > N> This broke for me on 11.0-CURRENT because I use: > > N> > > N> KERNCONFS=3D GENERIC GENERIC-NODEBUG > > N> > > N> and use installkernel with INSTKERNNAME. > > > > That's quite specific setup. Probably NO_INSTALLEXTRAKERNELS should > > be played with conditionally. > > It=E2=80=99s not an uncommon setup though. I have used it on all my CURRE= NT > machines for some time because I might want to be able to use INVARIANTS > kernels sometimes when doing kernel changes, and boot !INVARIANTS kernels > all of the time. > > I chose "?=3D yes=E2=80=9D because it=E2=80=99s better syntactic sugar th= an > `defined(NO_INSTALLEXTRAKERNELS) && ${NO_INSTALLKERNELS} !=3D =E2=80=9Cye= s=E2=80=9D` and it > works with pre-bmake (the other idiom that bmake allows that would work > here=E2=80=A6 although with more duplicity is `:Uyes`, which would break > installkernel on FreeBSD 9 machines or with fmake as the system make). > > Thanks! > -Ngie >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpU39MDRmxe4WYxCKKC_jHFiYOeyd%2BTBEROrCpk7X7Uwg>