Date: Sat, 20 Oct 2007 13:44:48 GMT From: bf <bf2006a@yahoo.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/117360: [PATCH]multimedia/gxine: respect CFLAGS Message-ID: <200710201344.l9KDimTZ047670@www.freebsd.org> Resent-Message-ID: <200710201350.l9KDo1Y6029151@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 117360
>Category: ports
>Synopsis: [PATCH]multimedia/gxine: respect CFLAGS
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 20 13:50:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: bf
>Release: 6.2-Stable i386
>Organization:
-
>Environment:
>Description:
I think it would be best to respect CFLAGS. If some flags are problematic, a note recommending a certain set and warning against others could be added, instead of forcing the users to adopt a default set or to make a custom build:
diff -ruN gxine.orig/Makefile gxine/Makefile
--- gxine.orig/Makefile Sat Oct 20 04:48:31 2007
+++ gxine/Makefile Sat Oct 20 04:49:30 2007
@@ -25,7 +25,7 @@
LDFLAGS="-L${LOCALBASE}/lib -I${X11BASE}/lib"
CONFIGURE_ARGS+=--x-includes=${X11BASE}/include \
--x-libraries=${X11BASE}/lib
-CFLAGS= -O2 -fno-strict-aliasing -pipe
+CFLAGS?= -O2 -fno-strict-aliasing -pipe
INSTALLS_ICONS= yes
MANLANG= "" de
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710201344.l9KDimTZ047670>