Date: Tue, 22 Sep 2015 22:26:10 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org> Cc: Warner Losh <imp@bsdimp.com>, Andrew Turner <andrew@fubar.geek.nz>, src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r288121 - projects/clang370-import/contrib/libc++/src/support Message-ID: <77B76EA2-1C5A-4B35-BBAA-78F1ECAC9754@FreeBSD.org> In-Reply-To: <1442949245.1224.229.camel@freebsd.org> References: <201509221734.t8MHYp0W052286@repo.freebsd.org> <00F42FF7-84D4-4C97-974F-C28DB36D4392@bsdimp.com> <9B0C3FE9-821B-470E-8AFC-F5B3DCE5B8F4@FreeBSD.org> <1442949245.1224.229.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 22 Sep 2015, at 21:14, Ian Lepore <ian@FreeBSD.org> wrote: > > On Tue, 2015-09-22 at 20:48 +0200, Dimitry Andric wrote: >> On 22 Sep 2015, at 20:37, Warner Losh <imp@bsdimp.com> wrote: ... >>> I’m not entirely sure that your ‘fix’ makes things actually safe, even if it >>> seems to make them work today. I’ll have to study it more closely. >> >> Probably not 100% safe, since the stub functions are just placeholders >> which aren't atomic at all. > > This is confusing. The fact that these are stubs and aren't atomic at > all is the problem. There's no reason not to have real implementations > on arm < v6, machine/atomic.h has all the common stuff implemented > already. They were not yet available in e.g. libgcc or libcompiler-rt, so I got link errors when clang was emitting calls to e.g. __atomic_add_fetch(). Andy has now fixed this with r288125, so I can revert this crude workaround. :-) -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.28 iEYEARECAAYFAlYBuWgACgkQsF6jCi4glqNn1wCcCViQNz3OdOGHO0CdaGhBhmDD G0cAni2E9WRuIqAeH262p8jskdgFyrnC =PFaM -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?77B76EA2-1C5A-4B35-BBAA-78F1ECAC9754>