Date: Sat, 17 Jul 2010 20:16:31 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Rui Paulo <rpaulo@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r210121 - head/sys/net Message-ID: <20100717181631.GA89827@onelab2.iet.unipi.it> In-Reply-To: <F87FEBC4-A02D-4237-B530-CA6C53292C62@FreeBSD.org> References: <201007151441.o6FEf6Lc015448@svn.freebsd.org> <F87FEBC4-A02D-4237-B530-CA6C53292C62@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 17, 2010 at 02:21:48PM +0100, Rui Paulo wrote: > > On 15 Jul 2010, at 15:41, Luigi Rizzo wrote: > > > Author: luigi > > Date: Thu Jul 15 14:41:06 2010 > > New Revision: 210121 > > URL: http://svn.freebsd.org/changeset/base/210121 > > > > Log: > > small portability fix to build on linux/windows > > Do we really want this, especially on sys? the alternative would be to keep a separate tree with cross platform sources, and periodically import the code in FreeBSD. This seems largely overkill considering that 1. most of the development of ipfw/dummynet occurs within FreeBSD and there are several people besides myself contributing features and bugfixes; 2. as you can see, the number and size of OS-specific parts is very very small (this was one of my goals when porting it) so there is no loss of readability. Also, I am deliberately avoiding any change that would cause a loss of performance on FreeBSD: in case, i put the extra burden on other platforms. cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100717181631.GA89827>