Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Jun 2015 22:27:59 +0000 (UTC)
From:      Garrett Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r284357 - head/sys/dev/acpi_support
Message-ID:  <201506132227.t5DMRxgO037044@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Sat Jun 13 22:27:59 2015
New Revision: 284357
URL: https://svnweb.freebsd.org/changeset/base/284357

Log:
  Fix inverted check by skipping over the model-specific checks if the maker
  or product is NULL, not if they are both not NULL
  
  Reported by: araujo, kib
  X-MFC with: r283678, r284336
  Pointyhat to: allanjude

Modified:
  head/sys/dev/acpi_support/acpi_ibm.c

Modified: head/sys/dev/acpi_support/acpi_ibm.c
==============================================================================
--- head/sys/dev/acpi_support/acpi_ibm.c	Sat Jun 13 22:01:21 2015	(r284356)
+++ head/sys/dev/acpi_support/acpi_ibm.c	Sat Jun 13 22:27:59 2015	(r284357)
@@ -485,7 +485,7 @@ acpi_ibm_attach(device_t dev)
 	/* Enable per-model events. */
 	maker = kern_getenv("smbios.system.maker");
 	product = kern_getenv("smbios.system.product");
-	if (maker != NULL && product != NULL)
+	if (maker == NULL && product == NULL)
 		goto nosmbios;
 
 	for (i = 0; i < nitems(acpi_ibm_models); i++) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201506132227.t5DMRxgO037044>