Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Jun 2018 22:05:24 +0200
From:      Oliver Pinter <oliver.pinter@hardenedbsd.org>
To:        Jonathan Anderson <jonathan@freebsd.org>
Cc:        Antoine Brodin <antoine@freebsd.org>, svn-src-head@freebsd.org,  "Robert N. M. Watson" <robert.watson@cl.cam.ac.uk>, src-committers <src-committers@freebsd.org>,  Eitan Adler <eadler@freebsd.org>, svn-src-all@freebsd.org
Subject:   Re: svn commit: r334931 - in head: . sys/sys
Message-ID:  <CAPQ4ffsMzUn=NemiTBQU2Ub=WMGSCLetEq51ycyLYTc=iBi2bw@mail.gmail.com>
In-Reply-To: <3D29EC4B-D05D-4485-98BD-8E5EB5C1E8E9@FreeBSD.org>
References:  <201806101915.w5AJFcZM001907@repo.freebsd.org> <CAALwa8mjroE5CgF0B9YWe9z4KaDWsNfmYKXswA97PR6wYPZLnQ@mail.gmail.com> <3D29EC4B-D05D-4485-98BD-8E5EB5C1E8E9@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 6/10/18, Jonathan Anderson <jonathan@freebsd.org> wrote:
> On 10 Jun 2018, at 16:49, Antoine Brodin wrote:
>
>> On Sun, Jun 10, 2018 at 9:15 PM, Eitan Adler <eadler@freebsd.org>
>> wrote:
>>> Author: eadler
>>> Date: Sun Jun 10 19:15:38 2018
>>> New Revision: 334931
>>> URL: https://svnweb.freebsd.org/changeset/base/334931
>>>
>>> Log:
>>>   Revert r334929
>>>
>>>   Apparently some software might depend on a header whose sole
>>> contents is
>>>   a `#warning` to remove it. Revert pending exp-run.
>>
>> Hi,
>>
>> It's not just a #warning,  there is a #include line below...
>> And after this change,  most ports that supported sandboxing were no
>> longer sandboxed.
>
> This used the be the primary header file for Capsicum, but we switched
> to the somewhat-more-portable sys/capsicum.h awhile ago. The current
> sys/capability.h includes the new header while emitting a warning in
> order to encourage people to switch to capsicum.h without breaking
> anything (yet). This is a transitional step, and I think the plan is to
> remove sys/capability.h after... maybe the 12-STABLE branch?
>

As second step, it would be fine to slip the #warning over to #error,
and fix the ports.

>
> Jon
> --
> Jonathan Anderson
> jonathan@FreeBSD.org
> _______________________________________________
> svn-src-head@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffsMzUn=NemiTBQU2Ub=WMGSCLetEq51ycyLYTc=iBi2bw>