Date: Thu, 1 Nov 2018 08:57:24 -0400 From: Charlie Li <ml@vishwin.info> To: Konstantin Belousov <kib@FreeBSD.org>, svn-src-head@freebsd.org, current@freebsd.org, toolchain@freebsd.org Subject: Re: svn commit: r339898 - head/lib/libc/amd64/sys Message-ID: <a2d14762-d6f9-4c3e-b3d3-efb7dcb2640f@vishwin.info> In-Reply-To: <201810300011.w9U0BUui038857@repo.freebsd.org> References: <201810300011.w9U0BUui038857@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mVY8JbXg2b5a6Xhjx6u9jQp2sIvHNgbzx Content-Type: multipart/mixed; boundary="VXCCe4XLvxobDqQWmYCQ7uJO8tYfzIBkk"; protected-headers="v1" From: Charlie Li <ml@vishwin.info> To: Konstantin Belousov <kib@FreeBSD.org>, svn-src-head@freebsd.org, current@freebsd.org, toolchain@freebsd.org Message-ID: <a2d14762-d6f9-4c3e-b3d3-efb7dcb2640f@vishwin.info> Subject: Re: svn commit: r339898 - head/lib/libc/amd64/sys References: <201810300011.w9U0BUui038857@repo.freebsd.org> In-Reply-To: <201810300011.w9U0BUui038857@repo.freebsd.org> --VXCCe4XLvxobDqQWmYCQ7uJO8tYfzIBkk Content-Type: text/plain; charset=utf-8 Content-Language: en-GB-large Content-Transfer-Encoding: quoted-printable On 29/10/2018 20:11, Konstantin Belousov wrote: > Author: kib > Date: Tue Oct 30 00:11:30 2018 > New Revision: 339898 > URL: https://svnweb.freebsd.org/changeset/base/339898 >=20 > Log: > Convert amd64_get/set_fs/gsbase to ifunc. > =20 > Note that this is the first use of ifuncs in our userspace. > =20 > Sponsored by: The FreeBSD Foundation > MFC after: 1 month >=20 > Deleted: > head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c > head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h > Modified: > head/lib/libc/amd64/sys/Makefile.inc > head/lib/libc/amd64/sys/amd64_get_fsbase.c > head/lib/libc/amd64/sys/amd64_get_gsbase.c > head/lib/libc/amd64/sys/amd64_set_fsbase.c > head/lib/libc/amd64/sys/amd64_set_gsbase.c >=20 Using LLVM 7 to build world, fails: --- amd64_get_fsbase.o --- /usr/src/lib/libc/amd64/sys/amd64_get_fsbase.c:60:1: error: ifunc resolver function must have no parameters --- amd64_get_gsbase.o --- /usr/src/lib/libc/amd64/sys/amd64_get_gsbase.c:60:1: error: ifunc resolver function must have no parameters DEFINE_UIFUNC(, int, amd64_get_gsbase, (void **), static) ^ /usr/local/obj/usr/src/amd64.amd64/tmp/usr/include/x86/ifunc.h:43:44: note: expanded from macro 'DEFINE_UIFUNC' --- amd64_get_fsbase.o --- DEFINE_UIFUNC(, int, amd64_get_fsbase, (void **), static) ^ /usr/local/obj/usr/src/amd64.amd64/tmp/usr/include/x86/ifunc.h:43:44: note: expanded from macro 'DEFINE_UIFUNC' --- amd64_get_gsbase.o --- qual ret_type name args __attribute__((ifunc(#name "_resolver"))); \= ^ --- amd64_get_fsbase.o --- qual ret_type name args __attribute__((ifunc(#name "_resolver"))); \= ^ 1 error generated. --- amd64_get_gsbase.o --- 1 error generated. *** [amd64_get_gsbase.o] Error code 1 make[4]: stopped in /usr/src/lib/libc CI appears green after this commit, so I'm inclined to pin this on yet another instance of LLVM 7 being stricter than LLVM 6. Backing out this revision allows the build to continue (successfully). --=20 Charlie Li Can't think of a witty .sigline today=E2=80=A6 (This email address is for mailing list use only; replace local-part with vishwin for off-list communication) --VXCCe4XLvxobDqQWmYCQ7uJO8tYfzIBkk-- --mVY8JbXg2b5a6Xhjx6u9jQp2sIvHNgbzx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE/3/Cqr5a+41PbEb+jnB43vIDq2wFAlva+DwACgkQjnB43vID q2ymnA//VPMjcUnWr85R3WDEugYWjNQZ1PRMzJoE5yl5meVrb4mN3cM8LAONid2x FsyKmEgnwRpvCuTzthyrqmzWA1mEBqzX6ruCsaP6dVCCDPwSrbDJjkQfuciXHK+J Ryv4QICrRctkuYwPoxk2MdX97vStdRutp7HzGeRhPDojTUCwzKB5mKOefVCwh2Nf p8XJ4Q0H003DKc3/zBqvcmM3eeuETq/T6ALokD2Vo2E6JBCbnO2p2LoObzowH9Ur hNF8nycIJRX0nyNXwKRh7GA9BojINq10JNW/pTi7Rnvl3nJgG0a2J7v2d2Ed5w73 pYriflzTZlZHHMWNwVVkClJkaOEaZhqf3CehIXD3BURSXPH58F5J7Qhl09CJ8HnH yhUiK+BLke7I7KNjenXyQLfdRsnKJ5WGbiI0ULBaMMjNWf7Z8ilFsFCjs4Z/KPTB ufvRL35VETlIs0NI2BR7kpYpihZWIBZzLc+RX+nMJ5UrvmhpZ+6w9VluesKeMdOE nIVIv7XV6Uop4AsmMgP8X/cMQsnBwv0m9RUAnS+KTgsdXM8VvHpsKl09XqdlYnRu 0IIJpwe9Aq2BphG8ys67d0XJIAENQs0YeX6/GzFctqgavAA0S+WU/WbIAff4EkxJ FV44ax4e64SGhUuCUc3r4ou1BHcOQgA8MlgTJdaltVgNbjaPHXs= =XSeE -----END PGP SIGNATURE----- --mVY8JbXg2b5a6Xhjx6u9jQp2sIvHNgbzx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a2d14762-d6f9-4c3e-b3d3-efb7dcb2640f>