Date: Tue, 16 Oct 2018 12:18:23 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Antoine Brodin <antoine@freebsd.org>, Ed Maste <emaste@freebsd.org>, Gerald Pfeifer <gerald@freebsd.org>, re <re@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339350 - head/contrib/elftoolchain/elfcopy Message-ID: <20181016101822.gxsuvtczywpxqmiy@ivaldir.net> In-Reply-To: <20181016072614.GO5335@kib.kiev.ua> References: <201810132126.w9DLQ73C022496@repo.freebsd.org> <CAALwa8k5k7T2Xy6jSq0bbj%2Biq0T_FwctOZ-=ZLkCU6eS1%2BCoKg@mail.gmail.com> <CAPyFy2Cv2ydYWmBvWxoM9ACw2iCnq7xfsngEyOPF7XNK7P8ckA@mail.gmail.com> <CAPyFy2B-Oc8rVk_iBd8z6ecK_htEF41CCEZ_9=29zMGwap5aKg@mail.gmail.com> <CAALwa8=rUZh=VaQL0Ln6TsrfaK7maAhdG88AD1ZyDc-UpDMxSQ@mail.gmail.com> <20181016072614.GO5335@kib.kiev.ua>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Tue, Oct 16, 2018 at 10:26:14AM +0300, Konstantin Belousov wrote:
> On Tue, Oct 16, 2018 at 07:39:32AM +0200, Antoine Brodin wrote:
> > On Mon, Oct 15, 2018 at 3:53 PM Ed Maste <emaste@freebsd.org> wrote:
> > > On Mon, 15 Oct 2018 at 07:13, Ed Maste <emaste@freebsd.org> wrote:
> > > > Hi Antoine, did you bisect to this rev or does it just look like the
> > > > most probable candidate? Can you copy a pair of differing .o files
> > > > (say, gcc/cc1plus-checksum.o) from the work dir to freefall?
> > >
> > > Antoine provided a tarball of the work dir to me, and pointed out that
> > > the *-checksum.o files are not interesting - they are warnings only
> > > and are present prior to the identified change.
> > >
> > > Comparing one of the other differing files, e.g.
> > > stage{2,3}-gcc/expmed.o, demonstrates the problem. Gcc's build
> > > machinery is reasonably obfuscated so I'm not sure of the exact set of
> > > operations, but I can infer that the stage2/stage3 comparison is
> > > running strip on the object files and then comparing the result. Gcc
> > > is encountering this part of my strip/objcopy change:
> > >
> > > > Stripping binaries with relocations
> > > > referencing removed symbols was already broken, and after this change
> > > > may still be broken in a different way.
> > >
> > > Stripping symbols and relocations from an object file is not a
> > > particularly useful operation, since the object then can't be linked
> > > or otherwise used. But it seems Gcc's stage comparison relies on this.
> > > I did try running "strip --strip-debug" on stage{2,3}-gcc/expmed.o (a
> > > reasonable operation on object files) and that produced identical
> > > output.
> > >
> > > It may well be that a further change to ELF Tool Chain's strip is
> > > warranted, but I suspect the most straightforward and reliable fix
> > > here will be to just have gcc use GNU strip.
> >
> > The attached patch for the gcc ports fixes the failures for me.
> >
> > Antoine
>
> > Index: lang/gcc48/Makefile
> > ===================================================================
> > --- lang/gcc48/Makefile (revision 482165)
> > +++ lang/gcc48/Makefile (working copy)
> > @@ -33,6 +33,7 @@
> > SUFFIX= ${PORTVERSION:C/([0-9]+).([0-9]+).*/\1\2/}
> > USES= compiler cpe gmake iconv libtool makeinfo perl5 tar:bzip2
> > USE_BINUTILS= yes
> > +BINARY_ALIAS= strip=${LOCALBASE}/bin/strip
> Shouldn't USE_BINUTILS automatically prefer all binaries from there to be
> used, instead of the base system variants ?
>
Strip is not in the list of binaries to override, probably something to fix.
Plus it expects the build system to respect the "classic" env var, which imho
should be replaced by BINARY_ALIAS when possible
Best regards,
Bapt
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlvFuuwACgkQY4mL3PG3
PlrmaA//XM6qWOpITz8r7S7Z97gRZTzelPvbw3z3/E3H69iU63lD4rMV/Danmv9n
K97tTv0lqU2yzfE9sS9Dx94ILAyH8/QTW4EQumDRVXPXR3wGyeGOAvVpdPpfOxAs
AEhwKsSTPflPAssk1Q+/CvNY64feoqWSzjGaJedWC2Ucv8yqGSYQPks3n0r3b5WV
MWsfKe2EN4S6RI5M0v4xdyFPq3BqdlDH8Vp0cUjFgvGDHXolf04RnvBBgZB/fkna
pYbUgPIzH/zH1DO5v1PPYsg6Rox7RW8RHSXhhu/jPG8HTOamYP0yEeVUL7HJWjUN
ubvYMyqkiysZP4wBzy6cqKmuYUSdjfcmnZgYvt1z4n32ski40j3YkcEyuM5sJjdm
qkBb0boegmEaDgquqE6uQcqtxLudHT5zbvXf1Ur1k2AgFyfIBOx1bNdISOZ/XWH0
DMhn7sbQxsc3dilhjeGbacDMRgH7zq+5af7E3ntkcyCD0us5/PdeTpIB+hpctJCQ
yQLrp1991SmEQdFjg+8wwl0br34EFRx6BeMEk/gKYjmzUUCLgzxZJahBtSyJV05e
07EL5BHKNg/ouqV7NjBPHvUWU+E1t1nPeyeYruAQt6KM1V9SWS9Bu5D1FTDsF18j
neRvpnuehMhkkjkC4mr5TXkJ3EZuFJgC/FqT5WtGvybL3DyDiPs=
=LU1Y
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181016101822.gxsuvtczywpxqmiy>