Date: Fri, 6 Apr 2018 01:16:22 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <royger@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332073 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include x86/include x86/x86 Message-ID: <20180406005848.S3128@besplex.bde.org> In-Reply-To: <201804051439.w35EdpMM049557@repo.freebsd.org> References: <201804051439.w35EdpMM049557@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 5 Apr 2018, [UTF-8] Roger Pau Monn=C3=A9 wrote: > Log: > x86: improve reservation of AP trampoline memory This has lots of style bugs. Mainly changing the KNF spelling of 'unsigned' as u_int to the verbose 'unsigned int' in code that used to be careful to use the KNF spelling. Bruce From owner-svn-src-all@freebsd.org Thu Apr 5 15:22:16 2018 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67665F8D534; Thu, 5 Apr 2018 15:22:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D16A18189A; Thu, 5 Apr 2018 15:22:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w35FM4aS039936 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Apr 2018 18:22:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w35FM4aS039936 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w35FM4Hq039935; Thu, 5 Apr 2018 18:22:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Apr 2018 18:22:04 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Warner Losh <imp@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331976 - head/sys/modules/cam Message-ID: <20180405152204.GV1774@kib.kiev.ua> References: <201804040237.w342b5EA074884@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201804040237.w342b5EA074884@repo.freebsd.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 05 Apr 2018 15:22:16 -0000 On Wed, Apr 04, 2018 at 02:37:05AM +0000, Warner Losh wrote: > Author: imp > Date: Wed Apr 4 02:37:05 2018 > New Revision: 331976 > URL: https://svnweb.freebsd.org/changeset/base/331976 > > Log: > Add nvme_da back. > > Now that it can co-exist in the kernel with nvd, add it back to the > cam module. > > Sponsored by: Netflix > > Modified: > head/sys/modules/cam/Makefile > > Modified: head/sys/modules/cam/Makefile > ============================================================================== > --- head/sys/modules/cam/Makefile Wed Apr 4 02:35:48 2018 (r331975) > +++ head/sys/modules/cam/Makefile Wed Apr 4 02:37:05 2018 (r331976) > @@ -46,6 +46,7 @@ SRCS+= ata_machdep.c > SRCS+= ata_pmp.c > SRCS+= nvme_all.c > SRCS+= nvme_xpt.c > +SRCS+= nvme_da.c > > EXPORT_SYMS= YES # XXX evaluate This change resulted in the following: Preloaded elf obj module "/boot/kernel/cam.ko" at 0xffffffff812bb898. link_elf_obj: symbol nvme_strvis undefined KLD file cam.ko - could not finalize loading KLD file ahci.ko - cannot find dependency "cam"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180406005848.S3128>