Date: Sun, 9 Jul 2023 21:06:42 -0600 From: Warner Losh <imp@bsdimp.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 29cbe944e928 - main - CONTRIBUTING.md: minor changes Message-ID: <CANCZdfq9o8qA%2B=CxOW1y5LybDqW0XvdNiFhcY_CjDEvVZf9g_w@mail.gmail.com> In-Reply-To: <ZKj_DU6rzJunuHLb@FreeBSD.org> References: <202307072123.367LNZ4J060993@gitrepo.freebsd.org> <ZKj_DU6rzJunuHLb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, Jul 8, 2023 at 12:15 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote: > > commit 29cbe944e9287c2e61928c456512d3990aaffdaa > > > > CONTRIBUTING.md: minor changes > > > > - Misspelled GitHub > > - angle bracket not escaped correctly > > - Double white spaces > > You've removed them, while they are typically used after full stops > as texts render better with them unless you're using proportional > font. > It's the modern way.... but WuerfelDev also had a commit that backed that part out that I didn't fold in... I'm still torn since I see so many conflicting things about it :( I'm leaning towards putting them back. Warner > ./danfe > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jul 8, 2023 at 12:15 AM Alexey Dokuchaev <<a href="mailto:danfe@freebsd.org">danfe@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote:<br> > commit 29cbe944e9287c2e61928c456512d3990aaffdaa<br> > <br> > CONTRIBUTING.md: minor changes<br> > <br> > - Misspelled GitHub<br> > - angle bracket not escaped correctly<br> > - Double white spaces<br> <br> You've removed them, while they are typically used after full stops<br> as texts render better with them unless you're using proportional<br> font.<br></blockquote><div><br></div><div>It's the modern way.... but WuerfelDev also had a commit that backed that part out that I didn't fold in...</div><div>I'm still torn since I see so many conflicting things about it :(</div><div><br></div><div>I'm leaning towards putting them back.</div><div><br></div><div>Warner<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> ./danfe<br> </blockquote></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq9o8qA%2B=CxOW1y5LybDqW0XvdNiFhcY_CjDEvVZf9g_w>