Date: Thu, 18 Sep 2008 09:38:31 +0200 From: "Alexander Leidinger" <Alexander@Leidinger.net> To: "Chagin Dmitry" <dchagin@freebsd.org> Cc: freebsd-net@freebsd.org, freebsd-emulation@freebsd.org Subject: Re: [PATCH] recvmsg() sendmsg() linux emulation Message-ID: <20080918093831.89545e2iu5zjgjgg@webmail.leidinger.net> In-Reply-To: <20080917190230.GA2947@dchagin.dialup.corbina.ru> References: <20080822112927.GZ99951@hoeg.nl> <20080822112946.GA97526@freebsd.org> <20080831110610.GA2380@dchagin.dialup.corbina.ru> <20080902085623.GA12395@freebsd.org> <20080917183801.GA2714@dchagin.dialup.corbina.ru> <20080917190230.GA2947@dchagin.dialup.corbina.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting "Chagin Dmitry" <dchagin@freebsd.org> (from Wed, 17 Sep 2008 23:02:30 +0400): > On Wed, Sep 17, 2008 at 10:38:01PM +0400, Chagin Dmitry wrote: >> >> Please review, any comment will be helpful. I did just a very quick look... > @@ -978,9 +1072,13 @@ linux_sendmsg(struct thread *td, struct > linux_sendmsg_args *args) > */ > if (msg.msg_control != NULL && msg.msg_controllen == 0) > msg.msg_control = NULL; > + > +#if defined(__amd64__) && defined(COMPAT_LINUX32) > + error = linux32_copyiniov(PTRIN(msg.msg_iov), msg.msg_iovlen, > + &iov, EMSGSIZE); > +#else > error = copyiniov(msg.msg_iov, msg.msg_iovlen, &iov, EMSGSIZE); > - if (error) > - return (error); > +#endif > msg.msg_iov = iov; > msg.msg_flags = 0; > error = linux_sendit(td, args->s, &msg, args->flags, UIO_USERSPACE); You've lost the error handling in the conditional. Bye, Alexander. -- BOFH excuse #266: All of the packets are empty http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080918093831.89545e2iu5zjgjgg>