Date: Thu, 18 Jul 2002 11:22:54 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Mark Murray <markm@FreeBSD.org> Subject: RE: cvs commit: src/sys/i386/include atomic.h Message-ID: <XFMail.20020718112254.jhb@FreeBSD.org> In-Reply-To: <20020718143939.M7896-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18-Jul-2002 Bruce Evans wrote: > On Wed, 17 Jul 2002, John Baldwin wrote: > >> On 17-Jul-2002 Mark Murray wrote: >> > markm 2002/07/17 09:19:37 PDT >> > >> > Modified files: >> > sys/i386/include atomic.h >> > Log: >> > Clean up the syntax WRT semicolons at the end of function-like-macros, and protect GCCisms >> > from >> > non-GNU compilers and lint. >> >> I would prefer you use #error instead of non-working dummy functions. > > This file already used #error for that. The purpose of the commit is to > specially break this for lint only. You're right, I was preferring #error for each function though. :) > I would prefer the file to be correctly ifdefed and fall back to extern > functions in cases that can't be implemented inline, much like > <machine/cpufunc.h>. Then it could be compiled by any C compiler. > The kernel just wouldn't link unless the extern functions were actually > implemented somewhere, and might run much slower if they were implemented. This is better than using #error. > Bruce -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020718112254.jhb>