Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Dec 2023 05:15:18 GMT
From:      Alex Richardson <arichardson@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 60e845ceef25 - main - jevents: fix bootstrapping on Linux with Clang 16
Message-ID:  <202312120515.3BC5FIdk079684@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by arichardson:

URL: https://cgit.FreeBSD.org/src/commit/?id=60e845ceef25533bfb60450549bea56a17b1e467

commit 60e845ceef25533bfb60450549bea56a17b1e467
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2023-12-12 05:10:14 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: 2023-12-12 05:14:56 +0000

    jevents: fix bootstrapping on Linux with Clang 16
    
    The glibc fts_open() callback type does not have the second const
    qualifier and it appears that Clang 16 errors by default for mismatched
    function pointer types. Add an ifdef to handle this case.
    
    Reviewed By:    imp, emaste
    Differential Revision: https://reviews.freebsd.org/D43000
---
 lib/libpmc/pmu-events/jevents.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/libpmc/pmu-events/jevents.c b/lib/libpmc/pmu-events/jevents.c
index ff7d3b226932..590b465af400 100644
--- a/lib/libpmc/pmu-events/jevents.c
+++ b/lib/libpmc/pmu-events/jevents.c
@@ -1355,7 +1355,11 @@ err_out:
 #include <fts.h>
 
 static int
+#ifdef __GLIBC__
+fts_compare(const FTSENT **a, const FTSENT **b)
+#else
 fts_compare(const FTSENT * const *a, const FTSENT * const *b)
+#endif
 {
 	return (strcmp((*a)->fts_name, (*b)->fts_name));
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202312120515.3BC5FIdk079684>