Date: Thu, 06 Jan 2011 12:06:01 -0700 From: Warner Losh <imp@bsdimp.com> To: freebsd-hackers@FreeBSD.org Subject: Re: broken INCLUDE in sys/conf/kern.pre.mk for opensolaris code? Message-ID: <4D261299.6090003@bsdimp.com> In-Reply-To: <20110106134531.GA81523@freebsd.org> References: <20110106014046.GA324@freebsd.org> <AANLkTi=9g8Ptt2OUhvdDncPX9Z=3h4=3p-XN32cMg4xN@mail.gmail.com> <20110106134531.GA81523@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/06/2011 06:45, Alexander Best wrote: > On Thu Jan 6 11, Sergey Kandaurov wrote: >> On 6 January 2011 04:40, Alexander Best<arundel@freebsd.org> wrote: >>> hi there, >>> >>> while building target buildkernel with 'clang -v' i noticed a lot of these >>> lines: >>> >>> ignoring nonexistent directory "/usr/subversion-src/sys/contrib/opensolaris/compat" >>> >>> i checked sys/conf/kern.pre.mk and there's a line refering to a non-existing >>> directory: >>> >>> # ... and OpenSolaris >>> INCLUDES+= -I$S/contrib/opensolaris/compat >> I guess that's leftover from early dtrace stages in perforce. >> See //depot/projects/dtrace/src/sys/contrib/opensolaris/compat/sys > ah i see. whom do i have to ping to get this fixed? i'm not sure if the include > is even necessary, because obviosly a kernel will build without it. the only > issue i had with cddl code is that when you compile and install world with > WITHOUT_CDDL=true, you cannot rebuild world with cddl support. but i don't > think that's something the include (even if it points to the correct directory) > can fix. Maybe we should just remove it and be on our way. Warner > cheers. > alex > >>> is suspect this should actually be: >>> >>> # ... and OpenSolaris >>> INCLUDES+= -I$S/cddl/compat/opensolaris >>> >>> but i'm not sure of it. >>> >> >> -- >> wbr, >> pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D261299.6090003>