Date: Fri, 8 Nov 2002 14:22:55 -0500 From: Hiten Pandya <hiten@angelica.unixdaemons.com> To: David Xu <davidxu@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 vm86.c Message-ID: <20021108142255.A31265@angelica.unixdaemons.com> In-Reply-To: <003c01c286c3$44e8d710$ef01a8c0@davidwnt>; from davidxu@FreeBSD.ORG on Fri, Nov 08, 2002 at 09:07:55AM %2B0800 References: <200211080109.gA819GZG073240@repoman.freebsd.org> <003c01c286c3$44e8d710$ef01a8c0@davidwnt>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 08, 2002 at 09:07:55AM +0800, David Xu wrote the words in effect of:
>
> ----- Original Message -----
> From: "David Xu" <davidxu@FreeBSD.org>
> To: <cvs-committers@FreeBSD.org>; <cvs-all@FreeBSD.org>
> Sent: Friday, November 08, 2002 9:09 AM
> Subject: cvs commit: src/sys/i386/i386 vm86.c
>
>
> > davidxu 2002/11/07 17:09:16 PST
> >
> > Modified files:
> > sys/i386/i386 vm86.c
> > Log:
> > use critical_enter/exit to add a critical section around BIOS call,
> > this unbreaks WITNESS.
> >
> > Pointed out by: jhb
> >
> > Revision Changes Path
> > 1.50 +9 -5 src/sys/i386/i386/vm86.c
>
> I turned WITNESS all the time, but it hadn't reported any error message
> when spin lock was used.
>
> David
>
Should this information be added into mutex(9) manual page. I remember
when I added this, after help from DES@ for the mutex profiling lock:
--% (kern_mutex.c)
static struct mtx mprof_mtx
MTX_SYSINIT(mprof, &mprof_mtx, "mutex profiling lock", MTX_SPIN | MTX_QUIET);
%--
--% (subr_witness.c)
static struct witness_order_list_entry order_lists[] = {
...
{ "mutex profiling lock", &lock_class_mtx_spin },
...
};
%--
Just a thought.
Cheers.
--
Hiten Pandya
hiten@unixdaemons.com, hiten@uk.FreeBSD.org, hiten@softweyr.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021108142255.A31265>