Date: Mon, 27 Oct 2014 15:29:02 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193135] [NEW PORT] www/seahub: Seafile web server front end Message-ID: <bug-193135-13-h3Jl2L6hYC@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193135-13@https.bugs.freebsd.org/bugzilla/> References: <bug-193135-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193135 John Marino <marino@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marino@FreeBSD.org --- Comment #18 from John Marino <marino@FreeBSD.org> --- I'm sorry nobody has looked at this for, well, 2 months. It looks ok to me except for this: Xdo-install: X @${ECHO_MSG} ">>> Installing scripts..." X @${MKDIR} -m 0755 ${STAGEDIR}${HAIWENDIR}seafile-server/runtime/ X @${INSTALL} -m 0755 ${WRKSRC}/runtime/seahub.conf \ X ${STAGEDIR}${HAIWENDIR}seafile-server/runtime/ X @${MKDIR} -m 0755 ${STAGEDIR}${SEAHUBDIR} X @cd ${WRKSRC} && ${COPYTREE_SHARE} . ${STAGEDIR}${SEAHUBDIR} X @${FIND} ${STAGEDIR}${SEAHUBDIR} -name "*.bak" -exec ${RM} {} \; X @${FIND} ${STAGEDIR}${SEAHUBDIR} -name "*.orig" -exec ${RM} {} \; The "@" suppresses the command. We only allow "@" suppression on mkdir commands in the install and post-install targets. Plus, while not technically wrong, I don't really like seeing post-extra and post-patch. Can you move the contents of post-extract to post-patch target? Especially since it gives us the opportunity to patch the .conf file if we need to? -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193135-13-h3Jl2L6hYC>