Date: Fri, 18 Jun 2004 15:21:18 +0200 From: Max Laier <max@love2party.net> To: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/pf/pfctl pfctl_parser.c Message-ID: <200406181521.25729.max@love2party.net> In-Reply-To: <xzpwu25vwqi.fsf@dwp.des.no> References: <200406171523.i5HFNpjs011498@repoman.freebsd.org> <xzpwu25vwqi.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Friday 18 June 2004 15:09, Dag-Erling Smørgrav wrote: > Max Laier <mlaier@FreeBSD.org> writes: > > Log: > > Fix printing of u_int64_t with a cast to unsigned long long. > > The correct fix is to cast it to uintmax_t and print it with %ju. Well, this is another correct fix. I chose casting to (unsigned long long) as this can be fed back to OpenBSD where there is no C99 and hence no uintmax_t or %ju. Please note that this is code in a vendor branch and it is my concern to keep the diffsize down. I cannot see any bad consequences in my fix, but maybe I overlooked something. In latter case, please tell me. -- Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBA0uxVXyyEoT62BG0RAkI+AJ96NFWGqE3tz5xxQU/UMFJPOxegJwCffcsp DCTqHxDwn0yCw9+DFAhFq1w= =8Znt -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406181521.25729.max>