Date: Fri, 24 Feb 2017 03:05:46 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pedro Giffuni <pfg@FreeBSD.org> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r314142 - head/sys/dev/ce Message-ID: <20170224030545.GA39731@FreeBSD.org> In-Reply-To: <d93f402e-d5f5-03c2-3652-2b6f55987288@FreeBSD.org> References: <201702231530.v1NFULwx024028@repo.freebsd.org> <CAJ5_RoCw8JEzWybqpsvBm%2BvRUqkVK76zcnvS9omdo79j7QaqTg@mail.gmail.com> <d93f402e-d5f5-03c2-3652-2b6f55987288@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 23, 2017 at 12:49:01PM -0500, Pedro Giffuni wrote: > On 2/23/2017 12:13 PM, Benjamin Kaduk wrote: > > On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <pfg@freebsd.org > > <mailto:pfg@freebsd.org>> wrote: > > @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) > > "UserRequest (%s:%d)\n", > > __FUNCTION__, __LINE__)); > > return; > > } > > - req->Command = TAU32_Configure_Commit | > > - TAU32_Tx_Stop | TAU32_Rx_Stop; > > +// req->Command = TAU32_Configure_Commit | > > +// TAU32_Tx_Stop | TAU32_Rx_Stop; > > > > Should probably stick to C-style comments, though. > > They are valid C99 comments but I understand what you mean, Using comments (regardless of style) for disabling a code block is wrong; may I suggest `#if 0' instead? (This also does not hurt `svn blame'.) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170224030545.GA39731>