Date: Fri, 13 Sep 2019 05:11:18 +0100 From: John Baldwin <jhb@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Baptiste Daroussin <bapt@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352248 - head/usr.sbin/ntp/libntp Message-ID: <eff51b5a-2f15-099a-4926-35b8030dc0ce@FreeBSD.org> In-Reply-To: <54c8efce3064f685c1948546bebaccc5f56a09c1.camel@freebsd.org> References: <201909121546.x8CFkwB7005702@repo.freebsd.org> <54c8efce3064f685c1948546bebaccc5f56a09c1.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/12/19 6:53 PM, Ian Lepore wrote: > On Thu, 2019-09-12 at 15:46 +0000, Baptiste Daroussin wrote: >> Author: bapt >> Date: Thu Sep 12 15:46:58 2019 >> New Revision: 352248 >> URL: https://svnweb.freebsd.org/changeset/base/352248 >> >> Log: >> Get the readline header from the installed header instead of the from the source >> location. >> > > How can this possibly be right? One of the hallmarks of our build > system is that it is self-contained in the sense that it uses the > sources to build the sources, not sources or files from the host > machine being used to do the build. I think the issue is that the readline compat headers are installed at /usr/include/edit/readline/foo.h, so you need the equivalent of -I/usr/include/edit. If there was a way to make -I honor --sysroot (e.g. -I=/usr/include/edit) then that might be the cleaner way to handle this. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eff51b5a-2f15-099a-4926-35b8030dc0ce>