Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Jan 2014 06:58:41 +0000 (UTC)
From:      Peter Grehan <grehan@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r261148 - head/sys/amd64/amd64
Message-ID:  <201401250658.s0P6wfDI065595@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: grehan
Date: Sat Jan 25 06:58:41 2014
New Revision: 261148
URL: http://svnweb.freebsd.org/changeset/base/261148

Log:
  Change RWX to XWR in comments to match intent and bit patterns
  in discussion of valid EPT pte protections.
  
  Discussed with:	neel
  MFC after:	3 days

Modified:
  head/sys/amd64/amd64/pmap.c

Modified: head/sys/amd64/amd64/pmap.c
==============================================================================
--- head/sys/amd64/amd64/pmap.c	Sat Jan 25 06:54:04 2014	(r261147)
+++ head/sys/amd64/amd64/pmap.c	Sat Jan 25 06:58:41 2014	(r261148)
@@ -5575,7 +5575,7 @@ safe_to_clear_referenced(pmap_t pmap, pt
 	KASSERT(pmap->pm_type == PT_EPT, ("invalid pm_type %d", pmap->pm_type));
 
 	/*
-	 * RWX = 010 or 110 will cause an unconditional EPT misconfiguration
+	 * XWR = 010 or 110 will cause an unconditional EPT misconfiguration
 	 * so we don't let the referenced (aka EPT_PG_READ) bit to be cleared
 	 * if the EPT_PG_WRITE bit is set.
 	 */
@@ -5583,7 +5583,7 @@ safe_to_clear_referenced(pmap_t pmap, pt
 		return (FALSE);
 
 	/*
-	 * RWX = 100 is allowed only if the PMAP_SUPPORTS_EXEC_ONLY is set.
+	 * XWR = 100 is allowed only if the PMAP_SUPPORTS_EXEC_ONLY is set.
 	 */
 	if ((pte & EPT_PG_EXECUTE) == 0 ||
 	    ((pmap->pm_flags & PMAP_SUPPORTS_EXEC_ONLY) != 0))



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401250658.s0P6wfDI065595>