Date: Sat, 18 Apr 2020 01:16:30 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r360058 - head/sys/dev/sound/pci/hda Message-ID: <202004180116.03I1GU2n089280@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste Date: Sat Apr 18 01:16:30 2020 New Revision: 360058 URL: https://svnweb.freebsd.org/changeset/base/360058 Log: hdac: replace printf for unowned lock with a lock assertion Reviewed by: markj, mav Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D24479 Modified: head/sys/dev/sound/pci/hda/hdac.c Modified: head/sys/dev/sound/pci/hda/hdac.c ============================================================================== --- head/sys/dev/sound/pci/hda/hdac.c Fri Apr 17 23:14:51 2020 (r360057) +++ head/sys/dev/sound/pci/hda/hdac.c Sat Apr 18 01:16:30 2020 (r360058) @@ -975,8 +975,7 @@ hdac_send_command(struct hdac_softc *sc, nid_t cad, ui int timeout; uint32_t *corb; - if (!hdac_lockowned(sc)) - device_printf(sc->dev, "WARNING!!!! mtx not owned!!!!\n"); + hdac_lockassert(sc); verb &= ~HDA_CMD_CAD_MASK; verb |= ((uint32_t)cad) << HDA_CMD_CAD_SHIFT; sc->codecs[cad].response = HDA_INVALID;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004180116.03I1GU2n089280>