Date: Tue, 6 Oct 2015 22:19:24 +0200 From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <dumbbell@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com>, s3erios@gmail.com Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288653 - in head/sys/dev/drm2: . i915 Message-ID: <56142CCC.7000807@FreeBSD.org> In-Reply-To: <20151004094649.GG11284@kib.kiev.ua> References: <201510040745.t947jbp7082807@repo.freebsd.org> <20151004094649.GG11284@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hQKVL1tg7rA5lq4WiDLcLkOwA95fU2IWN Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04.10.2015 11:46, Konstantin Belousov wrote: > On Sun, Oct 04, 2015 at 07:45:37AM +0000, Adrian Chadd wrote: >> * Add missing case statement (gen =3D=3D 3) in intel_gpu_reset(). > This seems to be wrong. The i915 and G33 chipsets do not have register= s > declared in the 8xx chipset documentation. More, i915 and G33 have dif= ferent > reset procedures. >=20 > The absence of '3' case was copied from the corresponding Linux kernel.= > Was this change tested, or is there a reference to upstream where the > handling was added in this manner ? You're right, even in Linux 3.8, the switch does not have a case for generation 3. >> * Replace M_WAITOK with M_NOWAIT when the return value of malloc is = checked (may be incorrect). > This is also incorrect. At least the modesetting pathes are executed i= n > the syscall context, and sleeping is allowed; the modesetting locks wer= e > selected to make sleeping possible. Using nowait causes random syscall= s > failure where the requests would succeed otherwise. My reasoning was that M_WAITOK could make the display hang/unresponsive while the memory is under pressure. The caller should be responsible for handling the error instead. In Linux, *alloc() calls may fail so application should already be responsible for that. --=20 Jean-S=E9bastien P=E9dron --hQKVL1tg7rA5lq4WiDLcLkOwA95fU2IWN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWFCzMXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTM4PMP/jbx0y2EkkYZws8m9E93uxrg m8DfAv5UNayNm9RrfpPE+Bp2HJrl67EIilsI2lVK8faEv5oYLv5gBCZRJhl8lU1z H+QxAaXaOYwofvZG2qTpK8j9ZavKQxUFtDhQluxp7U/oTmxhELnh90ssp/zLrRQ2 96VawrNFVMe6AXUWDmyfrQW6eN732I7w4wfkRGqRmooDRQh7JesBi2aUEEDcC7Ue uJXLgJ1nRGtnf4fVdQoleXJgrQuGNz/OP2+NOJjyq39nvOBnD8IbeKrgjYQWHTkE SwPnjEvV4pWiv3kR8LzqW6ZGpSbsZvLopsLNt8hkgmgrnu60JCilYAks+MLHO3GY C0b317PnFlNPbm2ktpn/3xnseDc35ITqQ1mn9lFqoaQT8mQPQ8v8OFlWwW7tkGpj SsSsOqeVU3HYk33xpHZjxj0orjw93am9/wEEexHuf+frG70oN+xzinZa5KkfiXWh V708z8qJjHpaZ2c33iNdppxQaUfqlTzeFIgK1reL343k2Tv6XZ+zVpJJnSlySrAP r4GlltF/7a7BuPAo6EteNRzZe4fM2oiMv03C/+VFCqBEPydHUmYPjOQvsPaOJl/3 ENJQEP5Ht4DXiEyjflaTzqfqvkmswk4ZMDlsrf0z3AFuVsS0+KTqsLiStQN/fykz dtH13BXsKGWvu0QbpGmS =gCDQ -----END PGP SIGNATURE----- --hQKVL1tg7rA5lq4WiDLcLkOwA95fU2IWN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56142CCC.7000807>