Date: Wed, 20 Feb 2008 01:58:36 -0800 From: Xin LI <delphij@delphij.net> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: freebsd-fs@freebsd.org, FreeBSD Current <freebsd-current@freebsd.org>, d@delphij.net Subject: Re: [PATCH FOR REVIEW] fsck_ffs: Recover from catastrophic damage Message-ID: <47BBF9CC.4030404@delphij.net> In-Reply-To: <20080220105614.eydtkfap4gogk0cw@webmail.leidinger.net> References: <47BBD864.3070905@delphij.net> <20080220105614.eydtkfap4gogk0cw@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexander Leidinger wrote: > Quoting Xin LI <delphij@delphij.net> (from Tue, 19 Feb 2008 23:36:04 > -0800): > >> Change summary: >> >> fsutil.c: >> - Really update standard superblock. fsck_ffs -b used to update the >> backup superblock which does not recover file systems which have bad >> master superblocks. >> - Instead of coredump, zero out whole cg if its signature is bad. >> >> inode.c: >> - Instead of coredump, zero out whole cg if its signature is bad. > > Does this modify (zero out) on-disk blocks? If yes, shouldn't this ask > for confirmation? My assumption is that if a cylinder group's magic number is damaged, then the whole stuff can not be trusted at all, but yes, I think this should come with a prompt, will add tomorrow. Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHu/nMi+vbBBjt66ARAqN9AJ4zRi6+h0f6R062vQyuEkET32saEACguKSs 4GxuVJdwFt7bIuKlGouO5Dk= =fMnQ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47BBF9CC.4030404>