Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Jun 2014 10:29:26 -0700
From:      Nathan Whitehorn <nwhitehorn@freebsd.org>
To:        Glen Barber <gjb@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Julio Merino <jmmv@FreeBSD.org>, src-committers@FreeBSD.org
Subject:   Re: svn commit: r267332 - head/release
Message-ID:  <53974076.9090003@freebsd.org>
In-Reply-To: <20140610172607.GS1209@hub.FreeBSD.org>
References:  <201406101705.s5AH5gt8007603@svn.freebsd.org> <53973EC7.10306@freebsd.org> <20140610172607.GS1209@hub.FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 06/10/14 10:26, Glen Barber wrote:
> On Tue, Jun 10, 2014 at 10:22:15AM -0700, Nathan Whitehorn wrote:
>> On 06/10/14 10:05, Julio Merino wrote:
>>> Author: jmmv
>>> Date: Tue Jun 10 17:05:41 2014
>>> New Revision: 267332
>>> URL: http://svnweb.freebsd.org/changeset/base/267332
>>>
>>> Log:
>>>    Strip out the test suite from the installation media.
>>>    This affects the disc1.iso, dvd1.iso and bootonly.iso files.
>>>    Obtained from:	gjb
>>>
>>> Modified:
>>>    head/release/Makefile
>>>
>>> Modified: head/release/Makefile
>>> ==============================================================================
>>> --- head/release/Makefile	Tue Jun 10 17:04:30 2014	(r267331)
>>> +++ head/release/Makefile	Tue Jun 10 17:05:41 2014	(r267332)
>>> @@ -155,7 +155,7 @@ system: packagesystem
>>>   	mkdir -p release
>>>   	cd ${WORLDDIR} && ${IMAKE} installkernel installworld distribution \
>>>   		DESTDIR=${.OBJDIR}/release WITHOUT_RESCUE=1 WITHOUT_KERNEL_SYMBOLS=1 \
>>> -		WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 WITHOUT_ATF=1 WITHOUT_LIB32=1
>>> +		WITHOUT_PROFILE=1 WITHOUT_SENDMAIL=1 MK_TESTS=no WITHOUT_LIB32=1
>>>   # Copy distfiles
>> Shouldn't this be "WITHOUT_TESTS" or the like? I thought we weren't supposed
>> to set MK_* at the command line.
> It does not work, or at least last I tried, because you cannot specify
> WITHOUT_FOO=1 if WITH_FOO=1 is set.  Using MK_FOO=no allows more
> granular tuning for these cases.
>
> Glen
>

Ah, OK. Just wanted to make sure it was deliberate!
-Nathan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53974076.9090003>