Date: Fri, 15 Sep 2017 15:31:07 -0600 From: Scott Long <scottl@samsco.org> To: Sean Bruno <sbruno@freebsd.org>, Stephen Hurd <shurd@FreeBSD.org> Cc: Cy Schubert <Cy.Schubert@komquats.com>, Ngie Cooper <yaneurabeya@gmail.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys Message-ID: <1EBD0641-002D-409C-B18E-AAB5FCDECEBA@samsco.org> In-Reply-To: <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> References: <201709130711.v8D7BlTS003204@slippy.cwsent.com> <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 13, 2017, at 9:12 AM, Sean Bruno <sbruno@freebsd.org> wrote: > >>>> #blamebruno >>>> >>>> Reviewed by: sbruno >>>> Approved by: sbruno (mentor) >>>> Sponsored by: Limelight Networks >>>> Differential Revision: https://reviews.freebsd.org/D12235 >>> >>> *gasps at the LoC count and number of changed drivers* >>> >>> Could someone please better break this up in the future..? >> >> Agreed. Down the road parsing out individual commits in this jumbo commit >> will be difficult to parse. IMO this may as well have simply been, import >> from https://github.com/mattmacy/networking/, just like Mr. Torvalds does >> at kernel.org. I expect to see a commit like this there but not here. Can >> we break this down to its functional commits? >> >> > > > This ridiculous loc was due to the amount of restructuring needed to get > us back to being in sync with our development. The future will not have > this big of a commit/change and should be more bite/fun sized. > > The #blamebruno tag in the commit log was to indicate that this was not > something Stephen was doing on his own, but was something that I had > induced over the last few months during testing. > This breaks my system. I prior to this commit, I had igb0 and igb1. Now I only have igb0, and it’s like igb1 isn’t even trying to attach. Unfortunately, this breaks my nfsroot setup, so I need to roll back my tree. Please let me know if there’s anything I can provide to help debugging. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1EBD0641-002D-409C-B18E-AAB5FCDECEBA>