Date: Wed, 4 May 2016 21:39:50 -0700 From: Adrian Chadd <adrian.chadd@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: Garrett Cooper <ngie@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r299108 - head/sys/sys Message-ID: <CAJ-VmomjZsWgw-3xjHDYZqvq6GLXzTrS=4HTYdyg6p2wOdLCag@mail.gmail.com> In-Reply-To: <2598444.C6bcyDe9AO@ralph.baldwin.cx> References: <201605050251.u452pVSN034598@repo.freebsd.org> <2598444.C6bcyDe9AO@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
oops! sorry! -a On 4 May 2016 at 20:17, John Baldwin <jhb@freebsd.org> wrote: > On Thursday, May 05, 2016 02:51:31 AM Garrett Cooper wrote: >> Author: ngie >> Date: Thu May 5 02:51:31 2016 >> New Revision: 299108 >> URL: https://svnweb.freebsd.org/changeset/base/299108 >> >> Log: >> Revert r299096 >> >> The change broke buildworld when building lib/libkvm >> >> This change likely needs to be run through a ports -exp run as a sanity >> check, as it might break downstream consumers. >> >> Pointyhat to: adrian >> Reported by: kargl (confirmed on $work workstation) >> Sponsored by: EMC / Isilon Storage Division > > 'struct foo *' can be use with a simple forward declare in headers without > requiring header pollution (and is often done for that reason). device_t > should be used in any .c files, but headers might need to stick with > 'struct device *' in a few cases for that reason. I suspect both of these > fall into that category. > > -- > John Baldwin >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomjZsWgw-3xjHDYZqvq6GLXzTrS=4HTYdyg6p2wOdLCag>