Date: Sat, 13 Sep 2014 21:49:24 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r271504 - in head/sys: dev/oce dev/vmware/vmxnet3 dev/xen/netfront net netinet ofed/drivers/net/mlx4 Message-ID: <54149FC4.7020307@selasky.org> In-Reply-To: <CAJ-Vmo=8oHuqM6U4E0E2Umwpc1DYWoA9ALkrx5xg46%2BcRyRCmw@mail.gmail.com> References: <201409130826.s8D8Q9Wx078339@svn.freebsd.org> <CAJ-Vmo=8oHuqM6U4E0E2Umwpc1DYWoA9ALkrx5xg46%2BcRyRCmw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/13/14 18:54, Adrian Chadd wrote: > Hi, > > Just for the record: > > * I'm glad you're tackling the TSO config stuff; > * I'm not glad you're trying to pack it into a u_int rather than > creating a new structure and adding fields for it. > > I appreciate that you're trying to rush this in before 10.1, but this > is exactly why things shouldn't be rushed in before release deadlines. > :) > > I'd really like to see this be broken out as a structure and the bit > shifting games for what really shouldn't be packed into a u_int fixed. > Otherwise this is going to be deadweight that has to persist past > 11.0. > Hi Adrian, I can make that change for -current, making the new structure and such. This change was intended for 10 where there is only one u_int for this information. Or do you want me to change that in 10 too? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54149FC4.7020307>