Date: Thu, 23 Jun 2005 06:49:00 GMT From: Peter Wemm <peter@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 78848 for review Message-ID: <200506230649.j5N6n02h012478@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=78848 Change 78848 by peter@peter_daintree on 2005/06/23 06:48:04 Cosmetic and doc bugs Affected files ... .. //depot/projects/hammer/sys/amd64/amd64/intr_machdep.c#37 edit .. //depot/projects/hammer/sys/amd64/amd64/local_apic.c#52 edit .. //depot/projects/hammer/sys/amd64/amd64/machdep.c#128 edit .. //depot/projects/hammer/sys/amd64/amd64/support.S#29 edit Differences ... ==== //depot/projects/hammer/sys/amd64/amd64/intr_machdep.c#37 (text+ko) ==== @@ -30,7 +30,7 @@ */ /* - * Machine dependent interrupt code for i386. For the i386, we have to + * Machine dependent interrupt code for amd64. For amd64, we have to * deal with different PICs. Thus, we use the passed in vector to lookup * an interrupt source associated with that vector. The interrupt source * describes which PIC the source belongs to and includes methods to handle ==== //depot/projects/hammer/sys/amd64/amd64/local_apic.c#52 (text+ko) ==== @@ -839,7 +839,7 @@ #ifdef SMP /* * Inter Processor Interrupt functions. The lapic_ipi_*() functions are - * private to the sys/i386 code. The public interface for the rest of the + * private to the sys/amd64 code. The public interface for the rest of the * kernel is defined in mp_machdep.c. */ int ==== //depot/projects/hammer/sys/amd64/amd64/machdep.c#128 (text+ko) ==== @@ -661,7 +661,7 @@ CTLFLAG_RW, &wall_cmos_clock, 0, ""); /* - * Initialize 386 and configure to run kernel + * Initialize amd64 and configure to run kernel */ /* ==== //depot/projects/hammer/sys/amd64/amd64/support.S#29 (text+ko) ==== @@ -202,13 +202,7 @@ /*****************************************************************************/ /* * Access user memory from inside the kernel. These routines and possibly - * the math- and DOS emulators should be the only places that do this. - * - * We have to access the memory with user's permissions, so use a segment - * selector with RPL 3. For writes to user space we have to additionally - * check the PTE for write permission, because the 386 does not check - * write permissions when we are executing with EPL 0. The 486 does check - * this if the WP bit is set in CR0, so we can use a simpler version here. + * should be the only places that do this. * * These routines set curpcb->onfault for the time they execute. When a * protection violation occurs inside the functions, the trap handler @@ -592,7 +586,7 @@ ret /* - * Handling of special 386 registers and descriptor tables etc + * Handling of special amd64 registers and descriptor tables etc * %rdi */ /* void lgdt(struct region_descriptor *rdp); */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506230649.j5N6n02h012478>