Date: Sun, 21 Sep 2025 11:56:56 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Guido Falsi <madpilot@freebsd.org> Cc: "Herbert J. Skuhra" <herbert@gojira.at>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 31ec8b6407fd - main - sys/netinet6: Implement RFC 7217 Message-ID: <aNBKeJwyBFpkt77b@cell.glebi.us> In-Reply-To: <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org> References: <202509201231.58KCVqBC047480@gitrepo.freebsd.org> <874iswhip4.wl-herbert@gojira.at> <bad8cb94-8243-468a-9919-a713a9426eae@FreeBSD.org> <07503de1-785e-4e4d-b4e4-0524aeb064e1@FreeBSD.org> <87jz1sc9fr.wl-herbert@gojira.at> <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 21, 2025 at 06:02:24PM +0200, Guido Falsi wrote: G> A C program would have included the system include and noticed the change, G> but this software has hardcoded the struct in go code and requires G> patching. G> G> I'm attaching a simple patch for the ports tree for this port, it compiles G> but I've not tested it at runtime, could you try applying this patch to the G> ports tree and recompile the port, and report back? G> G> Please note this is not a proper patch for the ports tree, it just fixes G> the problem, but would break it for anyone else, I'll produce a proper G> patch for the ports tree once I have confirmed the approach woks. Is struct nd_ifinfo something that is used as argument to ioctl(2)? If so, then adding counter_u64_t into it is not correct. I would suggest to not revert the change as a whole, but remove the counter only and bring struct nd_ifinfo back to original. The counter should probably go into struct in6_ifextra that is pointed by if->if_afdata[AF_INET6]. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aNBKeJwyBFpkt77b>