Date: Mon, 4 Jun 2007 18:25:08 +0000 (UTC) From: David Malone <dwmalone@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/amd64/amd64 tsc.c src/sys/amd64/isa clock.c src/sys/cam cam_xpt.c src/sys/cam/scsi scsi_all.c src/sys/compat/opensolaris/kern opensolaris_kstat.c src/sys/dev/acpica acpi_timer.c src/sys/dev/bge if_bge.c src/sys/dev/sound clone.c ... Message-ID: <200706041825.l54IP8RD042273@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
dwmalone 2007-06-04 18:25:08 UTC FreeBSD src repository Modified files: sys/amd64/amd64 tsc.c sys/amd64/isa clock.c sys/cam cam_xpt.c sys/cam/scsi scsi_all.c sys/compat/opensolaris/kern opensolaris_kstat.c sys/dev/acpica acpi_timer.c sys/dev/bge if_bge.c sys/dev/sound clone.c sys/dev/sound/pci atiixp.c emu10kx.c es137x.c via8233.c sys/dev/sound/pci/hda hdac.c sys/dev/sound/pcm ac97.c channel.c feeder.c feeder_rate.c sndstat.c sound.c vchan.c sys/dev/usb uplcom.c uvscom.c sys/geom/cache g_cache.c sys/geom/journal g_journal.c sys/geom/stripe g_stripe.c sys/i386/i386 elan-mmcr.c mp_clock.c tsc.c sys/i386/isa clock.c sys/kern kern_mbuf.c kern_poll.c kern_tc.c uipc_socket.c sys/netgraph ng_base.c sys/netgraph/bluetooth/common ng_bluetooth.c sys/netinet tcp_timewait.c sys/pc98/cbus clock.c Log: Despite several examples in the kernel, the third argument of sysctl_handle_int is not sizeof the int type you want to export. The type must always be an int or an unsigned int. Remove the instances where a sizeof(variable) is passed to stop people accidently cut and pasting these examples. In a few places this was sysctl_handle_int was being used on 64 bit types, which would truncate the value to be exported. In these cases use sysctl_handle_quad to export them and change the format to Q so that sysctl(1) can still print them. Revision Changes Path 1.208 +3 -3 src/sys/amd64/amd64/tsc.c 1.231 +1 -1 src/sys/amd64/isa/clock.c 1.188 +1 -1 src/sys/cam/cam_xpt.c 1.51 +1 -1 src/sys/cam/scsi/scsi_all.c 1.2 +3 -3 src/sys/compat/opensolaris/kern/opensolaris_kstat.c 1.41 +1 -1 src/sys/dev/acpica/acpi_timer.c 1.197 +1 -1 src/sys/dev/bge/if_bge.c 1.3 +1 -1 src/sys/dev/sound/clone.c 1.15 +1 -1 src/sys/dev/sound/pci/atiixp.c 1.11 +1 -1 src/sys/dev/sound/pci/emu10kx.c 1.66 +5 -5 src/sys/dev/sound/pci/es137x.c 1.38 +3 -3 src/sys/dev/sound/pci/hda/hdac.c 1.35 +3 -3 src/sys/dev/sound/pci/via8233.c 1.71 +1 -1 src/sys/dev/sound/pcm/ac97.c 1.119 +3 -3 src/sys/dev/sound/pcm/channel.c 1.42 +1 -1 src/sys/dev/sound/pcm/feeder.c 1.22 +3 -3 src/sys/dev/sound/pcm/feeder_rate.c 1.27 +2 -2 src/sys/dev/sound/pcm/sndstat.c 1.115 +7 -7 src/sys/dev/sound/pcm/sound.c 1.34 +1 -1 src/sys/dev/sound/pcm/vchan.c 1.42 +1 -1 src/sys/dev/usb/uplcom.c 1.31 +2 -2 src/sys/dev/usb/uvscom.c 1.2 +1 -1 src/sys/geom/cache/g_cache.c 1.12 +3 -3 src/sys/geom/journal/g_journal.c 1.32 +1 -1 src/sys/geom/stripe/g_stripe.c 1.35 +1 -1 src/sys/i386/i386/elan-mmcr.c 1.20 +1 -1 src/sys/i386/i386/mp_clock.c 1.208 +2 -2 src/sys/i386/i386/tsc.c 1.236 +1 -1 src/sys/i386/isa/clock.c 1.30 +1 -1 src/sys/kern/kern_mbuf.c 1.29 +5 -5 src/sys/kern/kern_poll.c 1.178 +3 -3 src/sys/kern/kern_tc.c 1.302 +2 -2 src/sys/kern/uipc_socket.c 1.7 +4 -4 src/sys/netgraph/bluetooth/common/ng_bluetooth.c 1.134 +1 -1 src/sys/netgraph/ng_base.c 1.286 +1 -1 src/sys/netinet/tcp_timewait.c 1.160 +1 -1 src/sys/pc98/cbus/clock.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706041825.l54IP8RD042273>