Date: Fri, 4 Dec 2015 23:42:51 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Bryan Drewery <bdrewery@freebsd.org> Cc: "Kenneth D. Merry" <ken@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291741 - head/sys/geom Message-ID: <20151204233052.J2220@besplex.bde.org> In-Reply-To: <56610B6B.8010708@FreeBSD.org> References: <201512040338.tB43cZY1053263@repo.freebsd.org> <56610B6B.8010708@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 3 Dec 2015, Bryan Drewery wrote:
> On 12/3/2015 7:38 PM, Kenneth D. Merry wrote:
>> g_disk_limit(struct disk *dp, struct bio *bp)
>> {
>> bool limited = false;
>> - off_t d_maxsize;
>> -
>> - d_maxsize = (bp->bio_cmd == BIO_DELETE) ?
>> - dp->d_delmaxsize : dp->d_maxsize;
>> + off_t maxsz = g_disk_maxsize(dp, bp);
>
> This looks like a style issue.
This looks like 5 style bugs and 0 issues:
3 old style bugs:
- use of bool
- initialization in declaration
- unsorted declarations
2 new style bugs:
- another initialization in declaration. A larger one
- lost blank line after declarations.
sys/geom had no instances of the bool style bug as recently as last
month. At the top level, it didn't even use boolean_t. In subdirectories,
it used boolean_t on 33 lines.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151204233052.J2220>