Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Mar 2023 23:36:56 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 5d96ca7a3072 - main - cap_sysctl tests: Serialize
Message-ID:  <202303302336.32UNauU8067619@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=5d96ca7a307279cf4bdb191b7074cd1efcd3b8e8

commit 5d96ca7a307279cf4bdb191b7074cd1efcd3b8e8
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-03-24 16:26:20 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2023-03-30 23:35:59 +0000

    cap_sysctl tests: Serialize
    
    These tests fail spuriously when run in parallel, since some of them
    write a value to a global sysctl, read it back, and expect to see the
    written value.  These tests complete quite quickly in any case.
    
    MFC after:      1 week
---
 lib/libcasper/services/cap_sysctl/tests/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/libcasper/services/cap_sysctl/tests/Makefile b/lib/libcasper/services/cap_sysctl/tests/Makefile
index d0d9f9bd7a0d..ec7439351c66 100644
--- a/lib/libcasper/services/cap_sysctl/tests/Makefile
+++ b/lib/libcasper/services/cap_sysctl/tests/Makefile
@@ -11,6 +11,9 @@ CFLAGS+=-DWITH_CASPER
 .endif
 LIBADD+=	nv
 
-TEST_METADATA.sysctl_test+=	required_user="root"
+# cap_sysctl tests modify global sysctl values and read them back, so
+# cannot be run in parallel.
+TEST_METADATA.sysctl_test+=	required_user="root" \
+				is_exclusive=true
 
 .include <bsd.test.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303302336.32UNauU8067619>