Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Aug 2023 08:46:37 GMT
From:      Hiroki Tagato <tagattie@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: e1cac91de631 - main - devel/electron{22,23,24,25}: fix build with CODECS option OFF
Message-ID:  <202308270846.37R8kbu1012805@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by tagattie:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e1cac91de631c97fb53645af88511d329ea45cbb

commit e1cac91de631c97fb53645af88511d329ea45cbb
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2023-08-27 08:44:10 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2023-08-27 08:46:30 +0000

    devel/electron{22,23,24,25}: fix build with CODECS option OFF
    
    Reported by:    crypt _at_ crypts _dot_ me (via private email)
    MFH:            2023Q3
---
 devel/electron22/files/patch-electron_build_args_all.gn     | 13 +++++++++++++
 devel/electron22/files/patch-electron_build_args_release.gn | 11 +++++++++++
 devel/electron23/files/patch-electron_build_args_all.gn     | 13 +++++++++++++
 devel/electron23/files/patch-electron_build_args_release.gn | 11 +++++++++++
 devel/electron24/files/patch-electron_build_args_all.gn     | 13 +++++++++++++
 devel/electron24/files/patch-electron_build_args_release.gn | 11 +++++++++++
 devel/electron25/files/patch-electron_build_args_all.gn     | 13 +++++++++++++
 devel/electron25/files/patch-electron_build_args_release.gn | 11 +++++++++++
 8 files changed, 96 insertions(+)

diff --git a/devel/electron22/files/patch-electron_build_args_all.gn b/devel/electron22/files/patch-electron_build_args_all.gn
new file mode 100644
index 000000000000..ffbf57a430de
--- /dev/null
+++ b/devel/electron22/files/patch-electron_build_args_all.gn
@@ -0,0 +1,13 @@
+--- electron/build/args/all.gn.orig	2023-08-27 00:45:03 UTC
++++ electron/build/args/all.gn
+@@ -17,8 +17,8 @@ v8_scriptormodule_legacy_lifetime = true
+ v8_enable_javascript_promise_hooks = true
+ 
+ enable_cdm_host_verification = false
+-proprietary_codecs = true
+-ffmpeg_branding = "Chrome"
++# proprietary_codecs = true
++# ffmpeg_branding = "Chrome"
+ 
+ enable_basic_printing = true
+ 
diff --git a/devel/electron22/files/patch-electron_build_args_release.gn b/devel/electron22/files/patch-electron_build_args_release.gn
new file mode 100644
index 000000000000..fd5b447a7008
--- /dev/null
+++ b/devel/electron22/files/patch-electron_build_args_release.gn
@@ -0,0 +1,11 @@
+--- electron/build/args/release.gn.orig	2023-08-27 00:45:41 UTC
++++ electron/build/args/release.gn
+@@ -7,7 +7,7 @@ is_official_build = true
+ # explicitly override here to build OpenH264 encoder/FFmpeg decoder.
+ # The initialization of the decoder depends on whether ffmpeg has
+ # been built with H.264 support.
+-rtc_use_h264 = proprietary_codecs
++# rtc_use_h264 = proprietary_codecs
+ 
+ # By default, Electron builds ffmpeg with proprietary codecs enabled. In order
+ # to facilitate users who don't want to ship proprietary codecs in ffmpeg, or
diff --git a/devel/electron23/files/patch-electron_build_args_all.gn b/devel/electron23/files/patch-electron_build_args_all.gn
new file mode 100644
index 000000000000..0efc01e7831a
--- /dev/null
+++ b/devel/electron23/files/patch-electron_build_args_all.gn
@@ -0,0 +1,13 @@
+--- electron/build/args/all.gn.orig	2023-08-27 01:37:11 UTC
++++ electron/build/args/all.gn
+@@ -17,8 +17,8 @@ v8_scriptormodule_legacy_lifetime = true
+ v8_enable_javascript_promise_hooks = true
+ 
+ enable_cdm_host_verification = false
+-proprietary_codecs = true
+-ffmpeg_branding = "Chrome"
++# proprietary_codecs = true
++# ffmpeg_branding = "Chrome"
+ 
+ enable_printing = true
+ 
diff --git a/devel/electron23/files/patch-electron_build_args_release.gn b/devel/electron23/files/patch-electron_build_args_release.gn
new file mode 100644
index 000000000000..544901c12bba
--- /dev/null
+++ b/devel/electron23/files/patch-electron_build_args_release.gn
@@ -0,0 +1,11 @@
+--- electron/build/args/release.gn.orig	2023-08-27 01:37:50 UTC
++++ electron/build/args/release.gn
+@@ -7,7 +7,7 @@ is_official_build = true
+ # explicitly override here to build OpenH264 encoder/FFmpeg decoder.
+ # The initialization of the decoder depends on whether ffmpeg has
+ # been built with H.264 support.
+-rtc_use_h264 = proprietary_codecs
++# rtc_use_h264 = proprietary_codecs
+ 
+ # By default, Electron builds ffmpeg with proprietary codecs enabled. In order
+ # to facilitate users who don't want to ship proprietary codecs in ffmpeg, or
diff --git a/devel/electron24/files/patch-electron_build_args_all.gn b/devel/electron24/files/patch-electron_build_args_all.gn
new file mode 100644
index 000000000000..3e62094fa104
--- /dev/null
+++ b/devel/electron24/files/patch-electron_build_args_all.gn
@@ -0,0 +1,13 @@
+--- electron/build/args/all.gn.orig	2023-08-26 12:06:22 UTC
++++ electron/build/args/all.gn
+@@ -14,8 +14,8 @@ v8_enable_snapshot_native_code_counters = false
+ v8_enable_javascript_promise_hooks = true
+ 
+ enable_cdm_host_verification = false
+-proprietary_codecs = true
+-ffmpeg_branding = "Chrome"
++# proprietary_codecs = true
++# ffmpeg_branding = "Chrome"
+ 
+ enable_printing = true
+ 
diff --git a/devel/electron24/files/patch-electron_build_args_release.gn b/devel/electron24/files/patch-electron_build_args_release.gn
new file mode 100644
index 000000000000..703688e76480
--- /dev/null
+++ b/devel/electron24/files/patch-electron_build_args_release.gn
@@ -0,0 +1,11 @@
+--- electron/build/args/release.gn.orig	2023-08-26 12:07:15 UTC
++++ electron/build/args/release.gn
+@@ -7,7 +7,7 @@ is_official_build = true
+ # explicitly override here to build OpenH264 encoder/FFmpeg decoder.
+ # The initialization of the decoder depends on whether ffmpeg has
+ # been built with H.264 support.
+-rtc_use_h264 = proprietary_codecs
++# rtc_use_h264 = proprietary_codecs
+ 
+ # By default, Electron builds ffmpeg with proprietary codecs enabled. In order
+ # to facilitate users who don't want to ship proprietary codecs in ffmpeg, or
diff --git a/devel/electron25/files/patch-electron_build_args_all.gn b/devel/electron25/files/patch-electron_build_args_all.gn
new file mode 100644
index 000000000000..c6f2581fb6ad
--- /dev/null
+++ b/devel/electron25/files/patch-electron_build_args_all.gn
@@ -0,0 +1,13 @@
+--- electron/build/args/all.gn.orig	2023-08-27 07:42:08 UTC
++++ electron/build/args/all.gn
+@@ -14,8 +14,8 @@ v8_enable_snapshot_native_code_counters = false
+ v8_enable_javascript_promise_hooks = true
+ 
+ enable_cdm_host_verification = false
+-proprietary_codecs = true
+-ffmpeg_branding = "Chrome"
++# proprietary_codecs = true
++# ffmpeg_branding = "Chrome"
+ 
+ enable_printing = true
+ 
diff --git a/devel/electron25/files/patch-electron_build_args_release.gn b/devel/electron25/files/patch-electron_build_args_release.gn
new file mode 100644
index 000000000000..710f5ec7fa6c
--- /dev/null
+++ b/devel/electron25/files/patch-electron_build_args_release.gn
@@ -0,0 +1,11 @@
+--- electron/build/args/release.gn.orig	2023-08-27 07:42:52 UTC
++++ electron/build/args/release.gn
+@@ -7,7 +7,7 @@ is_official_build = true
+ # explicitly override here to build OpenH264 encoder/FFmpeg decoder.
+ # The initialization of the decoder depends on whether ffmpeg has
+ # been built with H.264 support.
+-rtc_use_h264 = proprietary_codecs
++# rtc_use_h264 = proprietary_codecs
+ 
+ # By default, Electron builds ffmpeg with proprietary codecs enabled. In order
+ # to facilitate users who don't want to ship proprietary codecs in ffmpeg, or



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308270846.37R8kbu1012805>