Date: Tue, 3 Mar 2026 12:18:21 +0000 From: Brooks Davis <brooks@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Enji Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 912864912b71 - main - Run `make obj` before running `make test-includes` Message-ID: <aabRjaEUESOKOFZj@spindle.one-eyed-alien.net> In-Reply-To: <CANCZdfpdrkwj8RZtKubzg4feo5i61ivfwRSgwZM7U0k_9V%2B=pQ@mail.gmail.com> References: <69a678f3.3f811.148b0d7d@gitrepo.freebsd.org> <CANCZdfpdrkwj8RZtKubzg4feo5i61ivfwRSgwZM7U0k_9V%2B=pQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Tue, Mar 03, 2026 at 04:25:48AM -0700, Warner Losh wrote: > On Mon, Mar 2, 2026, 11:00???PM Enji Cooper <ngie@freebsd.org> wrote: > > > The branch main has been updated by ngie: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=912864912b71951f9a636190b1dba80528f588eb > > > > commit 912864912b71951f9a636190b1dba80528f588eb > > Author: Enji Cooper <ngie@FreeBSD.org> > > AuthorDate: 2026-03-03 05:59:50 +0000 > > Commit: Enji Cooper <ngie@FreeBSD.org> > > CommitDate: 2026-03-03 05:59:56 +0000 > > > > Run `make obj` before running `make test-includes` > > > > Before this change, `make test-includes` (run as part of buildworld) > > would place test files in the current directory, which would clutter up > > git clones. Run `make obj` beforehand to ensure that the files are put > > in `${.OBJDIR}` instead of `${.CURDIR}`. This helps cut down on the > > noise significantly when running commands like `git status`. > > > > I've never seen this happen. .OBJDIR is created automatically for me always > for the last 5 years... I run buildworld all the time. Can you explain when > / how it happens more specifically or back out the change? The commit message is unintentionally misleading and incomplete. I hit the problem a week or so ago when fixing gcc12 builds and lacked the time to follow up. test-includes is fine as part of buildworld, but when run directly from src does fill tools/build/test-includes with .c files if you blow away the objdir (which seems to the the only reliably way to cause test-includes to retest some more complex cases.) -- Brookshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aabRjaEUESOKOFZj>