Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Dec 2004 12:57:21 +0200
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/netgraph ng_base.c
Message-ID:  <20041223105721.GB83309@ip.net.ua>
In-Reply-To: <200412231048.iBNAmAM7042653@repoman.freebsd.org>
References:  <200412231048.iBNAmAM7042653@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--eJnRUKwClWJh1Khz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 23, 2004 at 10:48:10AM +0000, Gleb Smirnoff wrote:
> glebius     2004-12-23 10:48:10 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     sys/netgraph         ng_base.c=20
>   Log:
>   - sort includes
>   - remove duplicate include sys/sysctl.h
>  =20
>   Revision  Changes    Path
>   1.89      +4 -5      src/sys/netgraph/ng_base.c
>=20
>  #include <sys/param.h>
> -#include <sys/systm.h>
> +#include <sys/ctype.h>
>  #include <sys/errno.h>
>  #include <sys/kdb.h>
>  #include <sys/kernel.h>
>  #include <sys/limits.h>
>  #include <sys/malloc.h>
> -#include <sys/syslog.h>
> -#include <sys/sysctl.h>
> -#include <sys/queue.h>
>  #include <sys/mbuf.h>
> -#include <sys/ctype.h>
> +#include <sys/queue.h>
>  #include <sys/sysctl.h>
> +#include <sys/syslog.h>
> +#include <sys/systm.h>
>=20
Wrong.  <sys/systm.h> is special, it's a prerequisite for
<sys/mbuf.h>, according to mbuf(9) manpage.  It only works
now because <sys/mbuf.h> includes it for the _KERNEL case.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--eJnRUKwClWJh1Khz
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFByqSRqRfpzJluFF4RAtplAJ9o3yGPCj59O1oV4vzWZMfBXi07ywCgjUpJ
LaECkhDGedtf9H+eyd8JSfM=
=WXZC
-----END PGP SIGNATURE-----

--eJnRUKwClWJh1Khz--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041223105721.GB83309>