Date: Wed, 20 Feb 2019 23:54:34 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: Enji Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r344420 - in projects/import-googletest-1.8.1: lib/googletest/gmock lib/googletest/gtest share/mk Message-ID: <F6EA4AB0-2B53-493B-8762-62C76F797E5F@gmail.com> In-Reply-To: <201902210623.x1L6NWY9018774@pdx.rh.CN85.dnsmgr.net> References: <201902210623.x1L6NWY9018774@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 20, 2019, at 10:23 PM, Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >=20 >> Author: ngie >> Date: Thu Feb 21 04:47:44 2019 >> New Revision: 344420 >> URL: https://svnweb.freebsd.org/changeset/base/344420 = <https://svnweb.freebsd.org/changeset/base/344420>; >>=20 >> Log: >> Use gmock/gtest headers when PRIVATELIB is defined >>=20 >> The move to /usr/include/private prefixed paths seems to require a = bit more >> effort in order to compile programs. >>=20 >> Install the headers to /usr/include/private/g{mock,test}/... and = automatically >> include /usr/include/private in GTESTS_CXXFLAGS to make compilation = seamless. I >> will work on the more global problem later with @bdrewery. >=20 > Is this also hooked in to a (cd /usr/src/ && make includes) if gtest = is enabled? To clarify, are you asking if the headers are installed via =E2=80=9Cmake = includes=E2=80=9D? Yes, they were before and after this commit. The only thing that=E2=80=99s= changed is where they are installed (/usr/include/g{mock,test} -> = /usr/include/private/g{mock,test}). Cheers! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F6EA4AB0-2B53-493B-8762-62C76F797E5F>