Date: Mon, 29 Sep 2014 09:13:59 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: =?windows-1252?Q?Dag-Erling_Sm=F8rgrav?= <des@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272280 - head/lib/libpam/modules/pam_login_access Message-ID: <4197A538-C42B-44DD-A20A-C4E900478D69@FreeBSD.org> In-Reply-To: <201409290857.s8T8vamj094031@svn.freebsd.org> References: <201409290857.s8T8vamj094031@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 29 Sep 2014, at 08:57 , Dag-Erling Smørgrav <des@FreeBSD.org> wrote: > Author: des > Date: Mon Sep 29 08:57:36 2014 > New Revision: 272280 > URL: http://svnweb.freebsd.org/changeset/base/272280 > > Log: > Instead of failing when neither PAM_TTY nor PAM_RHOST are available, call > login_access() with "**unknown**" as the second argument. This will allow > “ALL" rules to match. > /scratch/tmp/bz/head.svn/lib/libpam/modules/pam_login_access/pam_login_access.c: In function 'pam_sm_acct_mgmt': /scratch/tmp/bz/head.svn/lib/libpam/modules/pam_login_access/pam_login_access.c:97: warning: format '%s' expects type 'char *', but argument 4 has type 'const void *' > Reported by: Tim Daneliuk <tundra@tundraware.com> > Tested by: dim@ > PR: 83099 193927 > MFC after: 3 days > > Modified: > head/lib/libpam/modules/pam_login_access/pam_login_access.c > > Modified: head/lib/libpam/modules/pam_login_access/pam_login_access.c > ============================================================================== > --- head/lib/libpam/modules/pam_login_access/pam_login_access.c Mon Sep 29 01:17:42 2014 (r272279) > +++ head/lib/libpam/modules/pam_login_access/pam_login_access.c Mon Sep 29 08:57:36 2014 (r272280) > @@ -94,8 +94,10 @@ pam_sm_acct_mgmt(pam_handle_t *pamh, int > PAM_VERBOSE_ERROR("%s is not allowed to log in on %s", > user, tty); > } else { > - PAM_VERBOSE_ERROR("PAM_RHOST or PAM_TTY required"); > - return (PAM_AUTHINFO_UNAVAIL); > + PAM_LOG("Checking login.access for user %s", user); > + if (login_access(user, "***unknown***") != 0) > + return (PAM_SUCCESS); > + PAM_VERBOSE_ERROR("%s is not allowed to log in", user); > } > > return (PAM_AUTH_ERR); > — Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4197A538-C42B-44DD-A20A-C4E900478D69>