Date: Sat, 23 Nov 2002 00:19:16 -0500 From: "Dan Langille" <dan@langille.org> To: Edwin Groothuis <edwin@mavetju.org> Cc: lioux@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, ports@FreeBSD.org Subject: Re: spaces in RUN_DEPENDS and BUILD_DEPENDS Message-ID: <3DDEC984.9923.C64183A3@localhost> In-Reply-To: <20021123003802.GE83552@k7.mavetju> References: <20021122152344.A50461@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23 Nov 2002 at 11:38, Edwin Groothuis wrote:
> On Fri, Nov 22, 2002 at 03:23:44PM -0800, Juli Mallett wrote:
> > * De: Edwin Groothuis <edwin@mavetju.org> [ Data: 2002-11-22 ]
> > [ Subjecte: Re: spaces in RUN_DEPENDS and BUILD_DEPENDS ]
> > > Err... there is a thinking in error in this: it takes both the
> > > values from the ports Makefile and the one added by the ports-framework.
> > >
> > > For example, look at archivers/fileroller:
> > > Your database contains:
> > >
> > > RUN_DEPENDS: bzip:/usr/ports/archivers/bzip lha:/usr/ports/archivers/lha rar:/usr/ports/archivers/rar lzop:/usr/ports/archivers/lzop
> >
> > > Looking at the Makefile (last modified 2002/11/13), I see this:
> > > RUN_DEPENDS= bzip:${PORTSDIR}/archivers/bzip \
> > > lha:${PORTSDIR}/archivers/lha \
> > > rar:${PORTSDIR}/archivers/rar \
> > > lzop:${PORTSDIR}/archivers/lzop
> > >
> > > make -V RUN_DEPENDS outputs this to:
> > > bzip:/usr/ports/archivers/bzip lha:/usr/ports/archivers/lha rar:/usr/ports/archivers/rar lzop:/usr/ports/archivers/lzop /usr/X11R6/share/gnome/.keep_me:/usr/ports/misc/gnomehier
> > >
> > > There are your double spaces, which weren't originally in the Makefile.
> >
> > Yes they were, where do you think the leading whitespace on the next line
> > goes? Hades?
>
> But that wasn't what the original report of Dan was about (or was it?)
The report mentions leading, trailing, and multiple spaces embedded
within the output. The problem came to my attention with this port
as mentioned a couple of days ago on cvs-all (look for
200211211852.gALIqr5b085974@repoman.freebsd.org and followups):
[dan@undef:~/ports/multimedia/gtksubtitler] $ export THINGS=`make -V
RUN_DEPENDS`
[dan@undef:~/ports/multimedia/gtksubtitler] $ echo "'$THINGS'"
' /usr/X11R6/share/gnome/.keep_me:/usr/ports/misc/gnomehier '
[dan@undef:~/ports/multimedia/gtksubtitler] $ export THINGS=`make -V
BUILD_DEPENDS`
[dan@undef:~/ports/multimedia/gtksubtitler] $ echo "'$THINGS'"
' '
[dan@undef:~/ports/multimedia/gtksubtitler] $
FreshPorts has been modified to cater for these superfluous spaces.
I thought it proper to raise the issue is case someone else decided
something was truly broken.
--
Dan Langille : http://www.langille.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3DDEC984.9923.C64183A3>