Date: Sun, 14 Jun 1998 05:53:41 -0700 (PDT) From: Bruce Evans <bde@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: cvs commit: src/sys/miscfs/procfs procfs_vnops.c Message-ID: <199806141253.FAA11719@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
bde 1998/06/14 05:53:41 PDT
Modified files:
sys/miscfs/procfs procfs_vnops.c
Log:
Avoid a 64-bit division in procfs_readdir(). Fixed related overflows.
Check args using the same expression as in fdesc and kernfs. The check
was actually already correct, modulo overflow. It could be tightened
up to either allow huge (aligned) offsets, treating them as EOF, or
disallow all offsets beyond EOF.
Didn't fix invalid address calculation &foo[i] where i may be out of
bounds.
Didn't fix shooting of foot using a private unportable dirent struct.
Revision Changes Path
1.59 +6 -10 src/sys/miscfs/procfs/procfs_vnops.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806141253.FAA11719>