Date: Mon, 19 Aug 2013 20:43:30 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: pjd@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r254484 - head/lib/libc/net Message-ID: <20130819.204330.2144498109880721402.hrs@allbsd.org> In-Reply-To: <201308181038.r7IAcxkM008487@svn.freebsd.org> References: <201308181038.r7IAcxkM008487@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Mon_Aug_19_20_43_30_2013_401)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Pawel Jakub Dawidek <pjd@FreeBSD.org> wrote in <201308181038.r7IAcxkM008487@svn.freebsd.org>: pj> Author: pjd pj> Date: Sun Aug 18 10:38:59 2013 pj> New Revision: 254484 pj> URL: http://svnweb.freebsd.org/changeset/base/254484 pj> pj> Log: pj> Consistently use 'af' as an argument name for address family. pj> Now both gethostbyname2(3) and gethostbyaddr(3) use the same argument name. pj> The same argument name is also used in implementations of those functions. pj> pj> Modified: pj> head/lib/libc/net/gethostbyname.3 pj> pj> Modified: head/lib/libc/net/gethostbyname.3 pj> ============================================================================== pj> --- head/lib/libc/net/gethostbyname.3 Sun Aug 18 10:33:46 2013 (r254483) pj> +++ head/lib/libc/net/gethostbyname.3 Sun Aug 18 10:38:59 2013 (r254484) pj> @@ -51,7 +51,7 @@ pj> .Ft struct hostent * pj> .Fn gethostbyname2 "const char *name" "int af" pj> .Ft struct hostent * pj> -.Fn gethostbyaddr "const void *addr" "socklen_t len" "int type" pj> +.Fn gethostbyaddr "const void *addr" "socklen_t len" "int af" pj> .Ft struct hostent * pj> .Fn gethostent void pj> .Ft void pj> @@ -107,7 +107,7 @@ in binary form pj> .Tn ASCII pj> form). pj> The pj> -.Fa type pj> +.Fa af pj> argument specifies the address family pj> (e.g.\& pj> .Dv AF_INET , AF_INET6 , I do not think we need to change this for consistency between the manual page and its implementation. gethostbyaddr()'s "int type" appears literally in POSIX and almost all systems have used that definition for a long time. -- Hiroki ----Security_Multipart(Mon_Aug_19_20_43_30_2013_401)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlISBOIACgkQTyzT2CeTzy2TzgCggcC9opOtNYppEufIHGVM4UCK tIUAn23y+5/RmqL9A53XWYZeUpiTEKwT =ATQ/ -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Aug_19_20_43_30_2013_401)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130819.204330.2144498109880721402.hrs>