Date: Sat, 27 Oct 2018 16:41:35 +0000 (UTC) From: Eugene Grosbein <eugen@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r339816 - head/sbin/mount_msdosfs Message-ID: <201810271641.w9RGfZ6f007305@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: eugen Date: Sat Oct 27 16:41:34 2018 New Revision: 339816 URL: https://svnweb.freebsd.org/changeset/base/339816 Log: mount_msdosfs: do not fail mounts requiring locale name conversion table that is already present in a kernel statically. For example, the command "mount_msdosfs -L ru_RU.KOI8-R" fails with error "mount_msdosfs: msdosfs_iconv: File exists" for a kernel having options LIBICONV and MSDOSFS_ICONV. After this change, it mounts successfully. MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D16951 Modified: head/sbin/mount_msdosfs/mount_msdosfs.c Modified: head/sbin/mount_msdosfs/mount_msdosfs.c ============================================================================== --- head/sbin/mount_msdosfs/mount_msdosfs.c Sat Oct 27 16:14:42 2018 (r339815) +++ head/sbin/mount_msdosfs/mount_msdosfs.c Sat Oct 27 16:41:34 2018 (r339816) @@ -46,6 +46,7 @@ static const char rcsid[] = #include <ctype.h> #include <err.h> +#include <errno.h> #include <grp.h> #include <locale.h> #include <pwd.h> @@ -308,17 +309,17 @@ set_charset(struct iovec **iov, int *iovlen, const cha build_iovec_argf(iov, iovlen, "cs_win", ENCODING_UNICODE); error = kiconv_add_xlat16_cspairs(ENCODING_UNICODE, cs_local); - if (error) + if (error && errno != EEXIST) return (-1); if (cs_dos != NULL) { error = kiconv_add_xlat16_cspairs(cs_dos, cs_local); - if (error) + if (error && errno != EEXIST) return (-1); } else { build_iovec_argf(iov, iovlen, "cs_dos", cs_local); error = kiconv_add_xlat16_cspair(cs_local, cs_local, KICONV_FROM_UPPER | KICONV_LOWER); - if (error) + if (error && errno != EEXIST) return (-1); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201810271641.w9RGfZ6f007305>