Date: Sun, 3 Jul 2011 12:39:49 +0200 From: Robert Millan <rmh@debian.org> To: Ed Maste <emaste@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] __FreeBSD_kernel__ Message-ID: <CAOfDtXPayCSvgUztkO_4ZsmmgxGfDU1%2BFszQ5-5ynd2--Bi-EA@mail.gmail.com> In-Reply-To: <20110703020827.GA5763@sandvine.com> References: <CAOfDtXPUxQO1zbnxh8sh%2By7g=d8QaH2svYtEQJ06L4d%2BQKG8VA@mail.gmail.com> <20110702193724.5c55a6c9@kan.dnsalias.net> <20110703020827.GA5763@sandvine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/7/3 Ed Maste <emaste@freebsd.org>: >> Alternatively, you should provide the symbol in >> similar way in which we provide __FreeBSD_version, through well-known >> header like sys/param.h and not pollute GCC. > > I suspect this is probably a reasonable alternative, but may mean software > will have to pick up an additional #include. Having to pick up an additional #include is sometimes a source of trouble, because: a) it's easy to forget (and hard to detect when having forgotten only breaks the other platform) b) one might not be able to assume this file is present (<sys/param.h> is not in POSIX, for example) Nevermind that, it's much better than not having the macro at all. -- Robert Millan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfDtXPayCSvgUztkO_4ZsmmgxGfDU1%2BFszQ5-5ynd2--Bi-EA>