Date: Sat, 12 Dec 2015 07:27:09 -0800 From: Devin Teske <devin@shxd.cx> To: =?utf-8?Q?Olivier_Cochard-Labb=C3=A9?= <olivier@cochard.me> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>, Devin Teske <dteske@freebsd.org> Subject: Re: svn commit: r291913 - head/tools/tools/nanobsd Message-ID: <4D007463-F8E5-4092-9FA4-0396E0A1444D@shxd.cx> In-Reply-To: <CA%2Bq%2BTcrSPfGgwy5majfhHZUdKiE4iO8rmkkJY3dzGWTUFut5yQ@mail.gmail.com> References: <201512070402.tB742V3Z081964@repo.freebsd.org> <CA%2Bq%2BTcrSPfGgwy5majfhHZUdKiE4iO8rmkkJY3dzGWTUFut5yQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 11, 2015, at 11:55 PM, Olivier Cochard-Labbé <olivier@cochard.me> wrote: > >> On Mon, Dec 7, 2015 at 5:02 AM, Warner Losh <imp@freebsd.org> wrote: > >> Author: imp >> Date: Mon Dec 7 04:02:31 2015 >> New Revision: 291913 >> URL: https://svnweb.freebsd.org/changeset/base/291913 >> >> Log: >> Generally use shorter, more idiomatic sh expressions in a bunch of >> places. >> >> Modified: >> head/tools/tools/nanobsd/defaults.sh (contents, props changed) > > > Hi, > > I beleive there is a tipo here : > >> >> Modified: head/tools/tools/nanobsd/defaults.sh >> ============================================================================== >> --- head/tools/tools/nanobsd/defaults.sh Mon Dec 7 04:02:19 2015 (r291912) >> +++ head/tools/tools/nanobsd/defaults.sh Mon Dec 7 04:02:31 2015 (r291913) >> >> ####################################################################### >> @@ -949,21 +949,21 @@ export_var ( ) { # Don't wawnt a subshe >> # Call this function to set defaults _after_ parsing options. >> # dont want a subshell otherwise variable setting is thrown away. >> set_defaults_and_export ( ) { >> - test -n "${NANO_OBJ}" || NANO_OBJ=/usr/obj/nanobsd.${NANO_NAME} >> - test -n "${MAKEOBJDIRPREFIX}" || MAKEOBJDIRPREFIX=${NANO_OBJ} >> - test -n "${NANO_DISKIMGDIR}" || NANO_DISKIMGDIR=${NANO_OBJ} >> + : ${NANO_OBJ:=/usr/obj/nanobsd.${NANO_NAME}} >> + : ${MAKEOBJDIRPREFIX:=${NANO_OBJ}} >> + : ${NANO_DISKIMGDIR=:${NANO_OBJ}} >> NANO_WORLDDIR=${NANO_OBJ}/_.w >> NANO_MAKE_CONF_BUILD=${MAKEOBJDIRPREFIX}/make.conf.build >> NANO_MAKE_CONF_INSTALL=${NANO_OBJ}/make.conf.install > > Notice the line: > : ${NANO_DISKIMGDIR=:${NANO_OBJ}} Author meant ":=" instead of "=:" -- Devin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D007463-F8E5-4092-9FA4-0396E0A1444D>